Uh oh!
There was an error while loading. Please reload this page.
test: reduce the use of private symbols in test-events-once.js - #58685
Merged
nodejs-github-bot merged 1 commit intoJun 15, 2025
Conversation
kt3kforce-pushed
the
test-reduce-use-of-private-symbol
branch
from
June 12, 2025 03:10
8286ec8 to
69252edCompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58685 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 637 637 Lines 188098 188098 Branches 36905 36896 -9 =======================================
+ Hits 169601 169605 +4 - Misses 11231 11236 +5 + Partials 7266 7257 -9 🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
Jun 14, 2025
nodejs-github-bot
commented
Jun 14, 2025
Collaborator
aduh95
approved these changes
Jun 15, 2025
nodejs-github-bot
commented
Jun 15, 2025
Collaborator
Landed in 139c2e1 |
targos pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58685 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Jun 23, 2025
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58685 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58685 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the usage of private symbol
kEventsintest/parallel/test-events-once.js.It'd be good to avoid using private items to make future refactoring easier