Skip to content

test_runner: prefer Atomics primordials - #58716

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:test_runner-atomics-primordials
Jun 17, 2025
Merged

test_runner: prefer Atomics primordials#58716
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:test_runner-atomics-primordials

Conversation

@aduh95

@aduh95aduh95 commented Jun 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Extracted from #58577

@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 15, 2025
@aduh95aduh95 mentioned this pull request Jun 15, 2025
Closed
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 15, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67464/

@codecov

codecovBot commented Jun 15, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (462c741) to head (ef2e084).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58716 +/- ##
=======================================
Coverage 90.15% 90.16% =======================================
Files 639 639 Lines 188201 188195 -6 Branches 36915 36916 +1 =======================================
+ Hits 169675 169679 +4 + Misses 11274 11273 -1 + Partials 7252 7243 -9
Files with missing linesCoverage Δ
lib/internal/test_runner/mock/loader.js95.58% <100.00%> (-0.09%)⬇️
lib/internal/test_runner/mock/mock.js99.27% <100.00%> (-0.01%)⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros

LiviaMedeiros commented Jun 15, 2025

Copy link
Copy Markdown
Member

/cc @Renegade334 just in case.

@Renegade334

Renegade334 commented Jun 15, 2025

Copy link
Copy Markdown
Member

Thanks all.

@Renegade334@aduh95
test_runner: prefer Atomics primordials
ef2e084
PR-URL: nodejs#58716
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95
aduh95force-pushed the test_runner-atomics-primordials branch from 7bba030 to ef2e084CompareJune 17, 2025 14:54
@aduh95

aduh95 commented Jun 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Landed in ef2e084

@aduh95
aduh95 merged commit ef2e084 into nodejs:mainJun 17, 2025
@aduh95
aduh95 deleted the test_runner-atomics-primordials branch June 17, 2025 14:54
RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
@Renegade334@RafaelGSS
test_runner: prefer Atomics primordials
c9e7b5e
PR-URL: #58716
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This was referenced Jun 23, 2025
Closed
Merged
richardlau pushed a commit that referenced this pull request Sep 20, 2025
@Renegade334@richardlau
test_runner: prefer Atomics primordials
d3259d6
PR-URL: #58716
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot mentioned this pull request Sep 22, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@pmarchinipmarchinipmarchini approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@LiviaMedeiros@Renegade334@ljharb@JakobJingleheimer@Ethan-Arrowood@pmarchini