Skip to content

src: pass resource on permission checks for spawn - #58758

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:enable-resource-pm-child-process
Jun 21, 2025
Merged

src: pass resource on permission checks for spawn#58758
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:enable-resource-pm-child-process

Conversation

@RafaelGSS

@RafaelGSSRafaelGSS commented Jun 18, 2025

Copy link
Copy Markdown
Member

src: pass resource on permission checks for spawn

This commit enhances the permission model errors
when no --allow-child-process is used and the error is emitted.

@RafaelGSSRafaelGSS added the permission Issues and PRs related to the Permission Model label Jun 18, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 18, 2025
geeksilva97
geeksilva97 reviewed Jun 18, 2025
View reviewed changes
Comment threadsrc/spawn_sync.cc Outdated
geeksilva97
geeksilva97 reviewed Jun 18, 2025
View reviewed changes
Comment threadsrc/spawn_sync.cc Outdated
@RafaelGSS
src: pass resource on permission checks for spawn
c1ed638
This commit enhances the permission model errors
when no --allow-child-process is used and the error
is emitted.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSSforce-pushed the enable-resource-pm-child-process branch from 1f9aeef to c1ed638CompareJune 18, 2025 20:28
@codecov

codecovBot commented Jun 18, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (f2e99c5) to head (c1ed638).
Report is 14 commits behind head on main.

Files with missing linesPatch %Lines
src/process_wrap.cc57.14%1 Missing and 2 partials ⚠️
src/spawn_sync.cc75.00%1 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #58758 +/- ##
==========================================
+ Coverage 90.02% 90.12% +0.10% 
==========================================
Files 639 639 Lines 188173 188204 +31 Branches 36831 36910 +79 ==========================================
+ Hits 169404 169624 +220 + Misses 11509 11325 -184 + Partials 7260 7255 -5
Files with missing linesCoverage Δ
src/node_process_methods.cc87.85% <100.00%> (ø)
src/process_wrap.cc66.66% <57.14%> (ø)
src/spawn_sync.cc68.68% <75.00%> (+0.10%)⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSSRafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 19, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67530/

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67570/

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67579/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2025
@nodejs-github-bot
nodejs-github-bot merged commit b04c4a4 into nodejs:mainJun 21, 2025
4 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2025

Copy link
Copy Markdown
Collaborator

Landed in b04c4a4

RafaelGSS added a commit that referenced this pull request Jun 23, 2025
@RafaelGSS
src: pass resource on permission checks for spawn
a0b1378
This commit enhances the permission model errors
when no --allow-child-process is used and the error
is emitted.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #58758
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@RafaelGSS@aduh95
src: pass resource on permission checks for spawn
0237f5e
This commit enhances the permission model errors
when no --allow-child-process is used and the error
is emitted.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #58758
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@RafaelGSS@aduh95
src: pass resource on permission checks for spawn
28bf6ed
This commit enhances the permission model errors
when no --allow-child-process is used and the error
is emitted.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #58758
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+1 more reviewer
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.permissionIssues and PRs related to the Permission Model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@RafaelGSS@nodejs-github-bot@anonrig@geeksilva97@marco-ippolito@bjohansebas@aduh95