Skip to content

assert: remove dead code - #58760

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
kt3k:remove-dead-code
Jun 29, 2025
Merged

assert: remove dead code#58760
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
kt3k:remove-dead-code

Conversation

@kt3k

@kt3kkt3k commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

code variable in getErrMessage util is not initialized anymore since this commit 43c380e and the handling of it is now dead code. This PR removes them.

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Jun 19, 2025
kt3k
kt3k commented Jun 19, 2025
View reviewed changes
Comment threadlib/internal/assert/utils.js Outdated

@kt3kkt3kJun 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is if (filename) { ... } else { return ... } structure above, and this check is unnecessary.

@kt3k
kt3kforce-pushed the remove-dead-code branch from 74fee45 to b1563bdCompareJune 19, 2025 04:35
@kt3kkt3k changed the title refactor(assert): remove dead codeassert: remove dead codeJun 19, 2025
@codecov

codecovBot commented Jun 19, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (214e4db) to head (b09eb11).
Report is 73 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58760 +/- ##
==========================================
- Coverage 90.13% 90.10% -0.04% 
==========================================
Files 639 640 +1 Lines 188192 188278 +86 Branches 36911 36917 +6 ==========================================
+ Hits 169634 169648 +14 - Misses 11287 11338 +51 - Partials 7271 7292 +21
Files with missing linesCoverage Δ
lib/internal/assert/utils.js92.08% <100.00%> (+2.19%)⬆️

... and 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67536/

Ethan-Arrowood
Ethan-Arrowood reviewed Jun 20, 2025
View reviewed changes
Comment threadlib/internal/assert/utils.js Outdated
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67656/

@gurgundaygurgunday added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Jun 26, 2025
BridgeAR
BridgeAR approved these changes Jun 26, 2025
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67702/ 💛

@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 29, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 7db30d7 into nodejs:mainJun 29, 2025
76 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator

Landed in 7db30d7

targos pushed a commit that referenced this pull request Jul 3, 2025
@kt3k@targos
assert: remove dead code
a118bfc
PR-URL: #58760
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@kt3k@aduh95
assert: remove dead code
1b076ef
PR-URL: #58760
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@kt3k@aduh95
assert: remove dead code
b19ffeb
PR-URL: #58760
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
@meegta

This comment was marked as spam.

Sign in to view
@kt3k
kt3k deleted the remove-dead-code branch August 5, 2025 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@legendecaslegendecaslegendecas approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@kt3k@nodejs-github-bot@meegta@lpinca@anonrig@legendecas@BridgeAR@Ethan-Arrowood@marco-ippolito@jasnell@gurgunday