Skip to content

[v20.x] test: skip broken sea on rhel8 - #58761

Closed
marco-ippolito wants to merge 1 commit into
nodejs:v20.x-stagingfrom
marco-ippolito:skip-flakes-rhel8
Closed

[v20.x] test: skip broken sea on rhel8#58761
marco-ippolito wants to merge 1 commit into
nodejs:v20.x-stagingfrom
marco-ippolito:skip-flakes-rhel8

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Jun 19, 2025

Copy link
Copy Markdown
Member

Refs: #58588

Should unblock the v20 release

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x labels Jun 19, 2025
@marco-ippolitomarco-ippolito changed the title test: skip broken sea on rhel8[v20.x] test: skip broken sea on rhel8Jun 19, 2025
@panvapanva mentioned this pull request Jun 19, 2025
Merged
@panvapanva added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2025
@github-actions

github-actionsBot commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

RaisinTen
RaisinTen reviewed Jun 19, 2025
View reviewed changes
Comment threadtest/sequential/sequential.status Outdated
mcollina
mcollina approved these changes Jun 19, 2025
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67532/

mhdawson
mhdawson approved these changes Jun 19, 2025
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67538/

marco-ippolito added a commit that referenced this pull request Jun 20, 2025
@marco-ippolito
test: skip broken sea on rhel8
850192b
PR-URL: #58761
Refs: #58588
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@marco-ippolito

marco-ippolito commented Jun 20, 2025

Copy link
Copy Markdown
MemberAuthor

Landed in 850192b

This was referenced Aug 15, 2025
Merged
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@panvapanvapanva approved these changes
@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marco-ippolito@nodejs-github-bot@mcollina@panva@anonrig@richardlau@mhdawson@RaisinTen