Skip to content

doc: updated fs - #5877

Closed
ToPal wants to merge 2 commits into
nodejs:v4.x-stagingfrom
ToPal:v4.x-staging
Closed

doc: updated fs#5877
ToPal wants to merge 2 commits into
nodejs:v4.x-stagingfrom
ToPal:v4.x-staging

Conversation

@ToPal

Copy link
Copy Markdown

See issue #5862.
Removed irrelevant data about fs.readFile in docs for version 4.x

nodejs#5862
removed irrelevant data about fs.readFile
@ToPalToPal mentioned this pull request Mar 23, 2016
@mscdexmscdex added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 23, 2016
@benjamingr

Copy link
Copy Markdown
Member

LGTM.

@targos

Copy link
Copy Markdown
Member

The same correction is needed for fs.writeFile() and fs.appendFile()

nodejs#5862
removed irrelevant data about fs.writeFile and fs.appendFile
@ToPal

Copy link
Copy Markdown
Author

@targos ok, I've fixed it

@targos

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@jasnell

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Mar 24, 2016
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.
PR-URL: #5877
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in v4.x-staging in 2d65b05

@jasnelljasnell closed this Mar 24, 2016
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.
PR-URL: #5877
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.
PR-URL: #5877
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ToPal@benjamingr@targos@jasnell@mscdex