Uh oh!
There was an error while loading. Please reload this page.
build: fix typo 'Stoage' to 'Storage' in help text - #58777
Merged
Conversation
lpinca
approved these changes
Jun 21, 2025
jasnell
approved these changes
Jun 21, 2025
juanarbol
approved these changes
Jun 21, 2025
nodejs-github-bot
commented
Jun 22, 2025
Collaborator
ganglike248
commented
Jun 22, 2025
ContributorAuthor
Hello maintainers, Could you please approve the workflow runs? I need to retrigger the CI due to test failures that appear to be unrelated to my changes. 🥹 Thank you for your time and consideration. 🙏 |
nodejs-github-bot
commented
Jun 22, 2025
Collaborator
nodejs-github-bot
commented
Jun 23, 2025
Collaborator
marco-ippolito
approved these changes
Jun 23, 2025
Ethan-Arrowood
approved these changes
Jun 23, 2025
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 23, 2025
Collaborator
Landed in 32be16b |
RafaelGSS pushed a commit
that referenced
this pull request
Jun 24, 2025
PR-URL: #58777 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58777 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58777 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix spelling error in --without-sqlite option help message.
This PR fixes a typo in the configure script where 'Stoage' was incorrectly written instead of 'Storage' in the help text for the --without-sqlite option on line 871.
Changes:
configureline 871: 'Stoage' → 'Storage'Why this change is needed:
The typo could confuse developers reading the help text for build configuration options. The correct term is "Web Storage API", not "Web Stoage API".
Testing:
python configure --helpThis is a minor documentation fix that doesn't require tests or changelog entry.
Additional Note:
This is my first contribution to this project, but I wanted to make a small contribution by fixing this typo to help improve the documentation quality.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.