Skip to content

fs: close dir before throwing if options.bufferSize is invalid - #58856

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:fs-dir-close-on-invalid-buffer
Jul 6, 2025
Merged

fs: close dir before throwing if options.bufferSize is invalid#58856
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:fs-dir-close-on-invalid-buffer

Conversation

@LiviaMedeiros

@LiviaMedeirosLiviaMedeiros commented Jun 26, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #58854

Test blocked on: #58855

@LiviaMedeirosLiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Jun 26, 2025
@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 26, 2025
@codecov

codecovBot commented Jun 26, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (4d5ee24) to head (eadbae5).
Report is 45 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58856 +/- ##
==========================================
- Coverage 90.10% 90.10% -0.01% 
==========================================
Files 640 640 Lines 188493 188499 +6 Branches 36971 36968 -3 ==========================================
+ Hits 169843 169848 +5 - Misses 11358 11361 +3 + Partials 7292 7290 -2
Files with missing linesCoverage Δ
lib/internal/fs/dir.js94.57% <100.00%> (+0.08%)⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros
LiviaMedeirosforce-pushed the fs-dir-close-on-invalid-buffer branch from 2155c48 to 67ea569CompareJune 29, 2025 05:53
@LiviaMedeirosLiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Jun 29, 2025
@LiviaMedeiros
LiviaMedeirosforce-pushed the fs-dir-close-on-invalid-buffer branch from 67ea569 to eadbae5CompareJune 29, 2025 05:57
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67717/

@juanarboljuanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 6, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 9ab9763 into nodejs:mainJul 6, 2025
64 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in 9ab9763

RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@LiviaMedeiros@RafaelGSS
fs: close dir before throwing if options.bufferSize is invalid
b378fc3
PR-URL: #58856Fixes: #58854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@LiviaMedeiros@aduh95
fs: close dir before throwing if options.bufferSize is invalid
fb8b85a
PR-URL: #58856Fixes: #58854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@LiviaMedeiros@aduh95
fs: close dir before throwing if options.bufferSize is invalid
c7ebf2e
PR-URL: #58856Fixes: #58854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs: opendirSync() leaks directory handle on error

5 participants

@LiviaMedeiros@nodejs-github-bot@jasnell@lpinca@juanarbol