Uh oh!
There was an error while loading. Please reload this page.
test: remove reliance on in-tree deps/undici - #58866
Merged
Merged
Conversation
Remove the dependency on the in-tree copy of Undici in `deps/undici` from `parallel/test-inspector-network-fetch`. For downstream rebuilders of Node.js using an externalized Undici it is not uncommon to remove `deps/undici` to ensure that the build is not using the in-tree copy.
LiviaMedeiros
approved these changes
Jun 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58866 +/- ##
==========================================
- Coverage 90.09% 90.09% -0.01%
==========================================
Files 640 640 Lines 188450 188450 Branches 36966 36963 -3 ==========================================
- Hits 169789 169784 -5 - Misses 11364 11387 +23 + Partials 7297 7279 -18 🚀 New features to boost your workflow:
|
nodejs-github-bot
commented
Jun 27, 2025
Collaborator
nodejs-github-bot
commented
Jun 28, 2025
Collaborator
marco-ippolito
approved these changes
Jun 28, 2025
legendecas
approved these changes
Jun 28, 2025
lpinca
approved these changes
Jun 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 29, 2025
Collaborator
Landed in 4c65776 |
targos pushed a commit
that referenced
this pull request
Jul 3, 2025
Remove the dependency on the in-tree copy of Undici in `deps/undici` from `parallel/test-inspector-network-fetch`. For downstream rebuilders of Node.js using an externalized Undici it is not uncommon to remove `deps/undici` to ensure that the build is not using the in-tree copy. PR-URL: #58866 Refs: #58865 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2025
Remove the dependency on the in-tree copy of Undici in `deps/undici` from `parallel/test-inspector-network-fetch`. For downstream rebuilders of Node.js using an externalized Undici it is not uncommon to remove `deps/undici` to ensure that the build is not using the in-tree copy. PR-URL: #58866 Refs: #58865 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 24, 2025
Remove the dependency on the in-tree copy of Undici in `deps/undici` from `parallel/test-inspector-network-fetch`. For downstream rebuilders of Node.js using an externalized Undici it is not uncommon to remove `deps/undici` to ensure that the build is not using the in-tree copy. PR-URL: #58866 Refs: #58865 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dependency on the in-tree copy of Undici in
deps/undicifromparallel/test-inspector-network-fetch. For downstream rebuilders of Node.js using an externalized Undici it is not uncommon to removedeps/undicito ensure that the build is not using the in-tree copy.Refs: #58865