Skip to content

test: replace .filter()[0] with .find() - #58872

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-filter0-find
Jun 29, 2025
Merged

test: replace .filter()[0] with .find()#58872
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-filter0-find

Conversation

@LiviaMedeiros

@LiviaMedeirosLiviaMedeiros commented Jun 28, 2025

Copy link
Copy Markdown
Member

Minor adjustment.

@LiviaMedeirosLiviaMedeiros added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 28, 2025
@github-actions

github-actionsBot commented Jun 28, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67703/

@codecov

codecovBot commented Jun 28, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (eaebfab) to head (2ff9782).
Report is 15 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58872 +/- ##
==========================================
+ Coverage 90.09% 90.10% +0.01% 
==========================================
Files 640 640 Lines 188450 188450 Branches 36966 36964 -2 ==========================================
+ Hits 169789 169812 +23 + Misses 11364 11352 -12 + Partials 7297 7286 -11

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeirosLiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 28, 2025
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2025
@nodejs-github-bot
nodejs-github-bot merged commit f6a4305 into nodejs:mainJun 29, 2025
73 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator

Landed in f6a4305

targos pushed a commit that referenced this pull request Jul 3, 2025
@LiviaMedeiros@targos
test: replace .filter()[0] with .find()
57c69ac
PR-URL: #58872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@LiviaMedeiros@aduh95
test: replace .filter()[0] with .find()
effca42
PR-URL: #58872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@LiviaMedeiros@aduh95
test: replace .filter()[0] with .find()
3fd187f
PR-URL: #58872
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiviaMedeiros@nodejs-github-bot@lpinca@aduh95