Uh oh!
There was an error while loading. Please reload this page.
doc: fix doc for Buffer.readInt32LE() - #5890
Closed
ghaiklor wants to merge 2 commits into
Closed
Conversation
Update example and signature for readInt32LE method.
jasnell
commented
Mar 24, 2016
Member
LGTM |
cjihrig
commented
Mar 24, 2016
Contributor
LGTM. Do the other similar methods have the same problem? If so, might as well fix those too. |
ghaiklor
commented
Mar 24, 2016
ContributorAuthor
ghaiklor
commented
Mar 24, 2016
ContributorAuthor
Ouch, mistake was not in offsets. They are correct. We have I'll update PR with correct version now. |
cjihrig
commented
Mar 24, 2016
Contributor
You're right. Thank you. |
bendiy
commented
Mar 25, 2016
@cjihrig I ran most of the other |
cjihrig
commented
Mar 25, 2016
Contributor
@bendiy thanks for investigating. |
thefourtheye pushed a commit
that referenced
this pull request
Mar 27, 2016
Update example of readInt32LE method. buf.readInt32LE(1) is supposed to throw an error as it has only four elements and it tries to read 32 bits from three bytes. Fixes: #5889 PR-URL: #5890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
thefourtheye
commented
Mar 27, 2016
Contributor
LGTM and landed in 1213535. I squashed the commits and reworded the commit log a bit. |
evanlucas pushed a commit
that referenced
this pull request
Mar 30, 2016
Update example of readInt32LE method. buf.readInt32LE(1) is supposed to throw an error as it has only four elements and it tries to read 32 bits from three bytes. Fixes: #5889 PR-URL: #5890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
commented
Mar 30, 2016
Contributor
should this be backported to v4? |
evanlucas pushed a commit
that referenced
this pull request
Mar 31, 2016
Update example of readInt32LE method. buf.readInt32LE(1) is supposed to throw an error as it has only four elements and it tries to read 32 bits from three bytes. Fixes: #5889 PR-URL: #5890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
thefourtheye
commented
Apr 2, 2016
Contributor
@thealphanerd Yes, this should be backported to 4.x |
MylesBorins pushed a commit
that referenced
this pull request
Apr 9, 2016
Update example of readInt32LE method. buf.readInt32LE(1) is supposed to throw an error as it has only four elements and it tries to read 32 bits from three bytes. Fixes: #5889 PR-URL: #5890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
existing APIs, or introduces new ones)?
Affected core subsystem(s)
doc
Description of change
Update example and signature for readInt32LE method. It fixes#5889.