Skip to content

doc: clarify details of TSC public and private meetings - #58925

Merged
nodejs-github-bot merged 10 commits into
nodejs:mainfrom
jasnell:jasnell/tsc-governance-clarifications
Jul 7, 2025
Merged

doc: clarify details of TSC public and private meetings#58925
nodejs-github-bot merged 10 commits into
nodejs:mainfrom
jasnell:jasnell/tsc-governance-clarifications

Conversation

@jasnell

@jasnelljasnell commented Jul 2, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Alternative to #58837

To be clear, I don't think any changes to our governance doc are needed, but others have proposed edits and additional requirements. This PR represents the version of those changes that I think would be better if any changes are made at all. See the discussion in #58837 for background.

@nodejs-github-bot

nodejs-github-bot commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 2, 2025
@jasnelljasnell mentioned this pull request Jul 2, 2025
Closed
@jasnelljasnell added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jul 2, 2025
mcollina
mcollina approved these changes Jul 2, 2025
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aduh95
aduh95 reviewed Jul 2, 2025
View reviewed changes
Comment threadGOVERNANCE.md Outdated
aduh95
aduh95 reviewed Jul 2, 2025
View reviewed changes
Comment threadGOVERNANCE.md Outdated
aduh95
aduh95 reviewed Jul 2, 2025
View reviewed changes
Comment threadGOVERNANCE.md Outdated
jasnell
jasnell commented Jul 2, 2025
View reviewed changes
Comment threadGOVERNANCE.md Outdated
jasnelland others added 3 commits July 2, 2025 06:12
@jasnell
Update GOVERNANCE.md
c68fff3
@jasnell@aduh95
Update GOVERNANCE.md
64ceabc
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@jasnell@aduh95
Update GOVERNANCE.md
f01ca88
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
jasnell
jasnell commented Jul 2, 2025
View reviewed changes
Comment threadGOVERNANCE.md Outdated
joyeecheung
joyeecheung reviewed Jul 2, 2025
View reviewed changes
Comment threadGOVERNANCE.md Outdated
Comment threadGOVERNANCE.md Outdated
jasnelland others added 2 commits July 2, 2025 08:50
@jasnell@joyeecheung
Update GOVERNANCE.md
878bf18
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell@joyeecheung
Update GOVERNANCE.md
2fe4f6c
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
joyeecheung reviewed Jul 2, 2025
View reviewed changes

@joyeecheungjoyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks. Still have a suggestion to align it with what we are already doing since that seems already good enough + a wording suggestion to make it more accurate.

Comment threadGOVERNANCE.md Outdated
Comment threadGOVERNANCE.md Outdated
@jasnell@joyeecheung
Update GOVERNANCE.md
fc9ce40
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
ShogunPanda
ShogunPanda approved these changes Jul 3, 2025
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasnell@joyeecheung
Update GOVERNANCE.md
5717b19
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
joyeecheung approved these changes Jul 4, 2025
View reviewed changes

@joyeecheungjoyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a wording suggestion. Thanks for putting it together :)

Comment threadGOVERNANCE.md Outdated
@jasnell@joyeecheung
Update GOVERNANCE.md
c4e9d5e
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

jasnell commented Jul 4, 2025

Copy link
Copy Markdown
MemberAuthor

@nodejs/tsc ... please take a look if you haven't done so already. I think this is ready to land. I'll merge end-of-day Monday if there are no objections posted.

@mhdawsonmhdawson mentioned this pull request Jul 6, 2025
Closed
@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Jul 7, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit a86765a into nodejs:mainJul 7, 2025
22 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in a86765a

RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@jasnell@RafaelGSS
doc: clarify details of TSC public and private meetings
78628d6
PR-URL: #58925
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@jasnell@aduh95
doc: clarify details of TSC public and private meetings
e5771c3
PR-URL: #58925
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@jasnell@aduh95
doc: clarify details of TSC public and private meetings
640e75b
PR-URL: #58925
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Jul 27, 2025
@jasnell@aduh95
doc: clarify details of TSC public and private meetings
b8885a2
PR-URL: #58925
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@joyeecheungjoyeecheung mentioned this pull request Jul 27, 2025
Merged
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
@mcollinamcollina mentioned this pull request Jul 30, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
@targostargostargos approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@MoLowMoLowMoLow approved these changes
@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@jasnell@nodejs-github-bot@mcollina@ShogunPanda@targos@joyeecheung@MoLow@aduh95@RafaelGSS@marco-ippolito@RaisinTen