Skip to content

doc: move "Core Promise APIs" to "Completed initiatives" - #58934

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:retire-core-promises-strategic-init
Jul 4, 2025
Merged

doc: move "Core Promise APIs" to "Completed initiatives"#58934
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:retire-core-promises-strategic-init

Conversation

@aduh95

@aduh95aduh95 commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

There haven't been much more progress, it seems safe to assume what could realistically be done has been done.

Closes: nodejs/TSC#1094

@nodejs-github-bot

nodejs-github-bot commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 2, 2025
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2025
@ljharb

ljharb commented Jul 2, 2025

Copy link
Copy Markdown
Member

it'd be nice to get child_process done before calling it "completed"; i've had it on my list to do but haven't made time yet.

@jasnell

jasnell commented Jul 2, 2025

Copy link
Copy Markdown
Member

@ljharb ... there's really nothing preventing continued work. This is really just to remove it from the brief review we have of these during the TSC meetings. This was initially added as a strategic initiative many years ago when it was still controversial that we would adopt promises widely at all. Since then it's been a steady stream of "no updates" reports in the TSC meetings that don't really have any value.

@joyeecheung

joyeecheung commented Jul 2, 2025

Copy link
Copy Markdown
Member

Note that it can be brought back to the ongoing list again if you have work that you want to report/get feedback from the TSC for a sustained period (for one-off TSC intervention requests, tagging tsc-agenda would suffice. Though I don't expect TSC oversight to be necessary for work in this line). @ljharb

@ljharb

ljharb commented Jul 2, 2025

Copy link
Copy Markdown
Member

ah ok, gotcha. i'll keep it on my list then :-) thanks!

mcollina
mcollina approved these changes Jul 2, 2025
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95

aduh95 commented Jul 3, 2025

Copy link
Copy Markdown
ContributorAuthor

@ljharb yeah you're most welcome to keep working on it, just so you know a satisfying async API would probably require some changes at the libuv level – JS only solutions tend to struggle to get traction/consensus, e.g. #45774

@LiviaMedeirosLiviaMedeiros changed the title doc: more "Core Promise APIs" to "Completed initiatives"doc: move "Core Promise APIs" to "Completed initiatives"Jul 3, 2025
LiviaMedeiros
LiviaMedeiros approved these changes Jul 3, 2025
View reviewed changes

@LiviaMedeirosLiviaMedeiros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this might need s/more/move/ in the commit message

@aduh95
aduh95 merged commit 19876f4 into nodejs:mainJul 4, 2025
23 checks passed
@aduh95

aduh95 commented Jul 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Landed in 19876f4

@aduh95
aduh95 deleted the retire-core-promises-strategic-init branch July 4, 2025 22:35
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@aduh95@RafaelGSS
doc: move "Core Promise APIs" to "Completed initiatives"
8d4f6a0
PR-URL: #58934Fixes: nodejs/TSC#1094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 added a commit that referenced this pull request Jul 21, 2025
@aduh95
doc: move "Core Promise APIs" to "Completed initiatives"
be03633
PR-URL: #58934Fixes: nodejs/TSC#1094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 added a commit that referenced this pull request Jul 24, 2025
@aduh95
doc: move "Core Promise APIs" to "Completed initiatives"
3856aee
PR-URL: #58934Fixes: nodejs/TSC#1094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Core Promise Initiative status

11 participants

@aduh95@nodejs-github-bot@ljharb@jasnell@joyeecheung@mcollina@lpinca@marco-ippolito@RaisinTen@atlowChemi@LiviaMedeiros