Skip to content

test: deflake test-runner-watch-mode-kill-signal - #58952

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/deflake-watch-mode-kill-signal-test
Jul 7, 2025
Merged

test: deflake test-runner-watch-mode-kill-signal#58952
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/deflake-watch-mode-kill-signal-test

Conversation

@dario-piotrowicz

@dario-piotrowiczdario-piotrowicz commented Jul 3, 2025•
edited
Loading

Copy link
Copy Markdown
Member

While trying to deflake the tests I've refactored making them much clearer and more performant (since there are no longer setTimeout calls), as far as I can tell the flake is also gone 🙂

Results:

Ref: nodejs/reliability#1250

@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 3, 2025
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67828/

@dario-piotrowiczdario-piotrowicz added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 3, 2025
@dario-piotrowicz
dario-piotrowiczforce-pushed the dario/deflake-watch-mode-kill-signal-test branch 2 times, most recently from c40725d to 4c1b29fCompareJuly 3, 2025 23:19
@dario-piotrowicz
dario-piotrowiczforce-pushed the dario/deflake-watch-mode-kill-signal-test branch from 4c1b29f to 971a1acCompareJuly 4, 2025 23:04
@dario-piotrowicz
dario-piotrowicz marked this pull request as ready for review July 5, 2025 00:02
@codecov

codecovBot commented Jul 5, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (aad9030) to head (971a1ac).
Report is 26 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58952 +/- ##
==========================================
+ Coverage 89.96% 90.06% +0.09% 
==========================================
Files 640 640 Lines 188454 188471 +17 Branches 36892 36979 +87 ==========================================
+ Hits 169546 169739 +193 + Misses 11608 11430 -178 - Partials 7300 7302 +2

see 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-ArrowoodEthan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2025
@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67877/

@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67879/

@dario-piotrowiczdario-piotrowicz added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 35c85a2 into nodejs:mainJul 7, 2025
78 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in 35c85a2

@dario-piotrowicz
dario-piotrowicz deleted the dario/deflake-watch-mode-kill-signal-test branch July 7, 2025 21:17
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@dario-piotrowicz@RafaelGSS
test: deflake test-runner-watch-mode-kill-signal
94f9424
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@dario-piotrowicz@aduh95
test: deflake test-runner-watch-mode-kill-signal
6f6953d
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@dario-piotrowicz@aduh95
test: deflake test-runner-watch-mode-kill-signal
ae9018d
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Jul 27, 2025
@dario-piotrowicz@aduh95
test: deflake test-runner-watch-mode-kill-signal
43d2ad8
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@MoLowMoLowMoLow approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung

Assignees

No one assigned

Labels

flaky-testIssues and PRs related to the tests with unstable failures on the CI.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dario-piotrowicz@nodejs-github-bot@jasnell@MoLow@Ethan-Arrowood@atlowChemi