Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-net-socket-timeout - #5902
Merged
Merged
Conversation
mscdexforce-pushed
the
test-flaky-net-socket-timeout
branch
from
March 25, 2016 16:02
fea5486 to
9d26d1fComparebnoordhuis
commented
Mar 25, 2016
Member
LGTM |
mscdex
commented
Mar 25, 2016
ContributorAuthor
CI is green except for a couple of unrelated test failures. Stress test passes. |
jasnell
commented
Mar 26, 2016
Member
LGTM |
mscdexforce-pushed
the
test-flaky-net-socket-timeout
branch
from
March 26, 2016 08:22
9d26d1f to
cf87ad5CompareFixes: nodejs#5892 PR-URL: nodejs#5902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
mscdexforce-pushed
the
test-flaky-net-socket-timeout
branch
from
March 26, 2016 08:23
cf87ad5 to
8b2e437Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
Description of change
Fixes a flaky test due to short timeouts on slow systems.
Fixes: #5902
Stress test: https://ci.nodejs.org/job/node-stress-single-test/569
CI: https://ci.nodejs.org/job/node-test-pull-request/2064/