Skip to content

test: move dns test to test/internet - #5905

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:move-dns-test
Closed

test: move dns test to test/internet#5905
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:move-dns-test

Conversation

@bnoordhuis

Copy link
Copy Markdown
Member

parallel/test-dns-cares-domains needs a working internet connection
to function (or a local DNS resolver that returns an answer quickly),
otherwise it times out. Move it to test/internet.

I'm omitting the CI because test/internet is not tested at the moment.

parallel/test-dns-cares-domains needs a working internet connection
to function (or a local DNS resolver that returns an answer quickly),
otherwise it times out. Move it to test/internet.
@bnoordhuisbnoordhuis added the test Issues and PRs related to the tests. label Mar 25, 2016
@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

@mscdexmscdex added the dns Issues and PRs related to the dns subsystem. label Mar 25, 2016
@jasnell

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Mar 26, 2016
parallel/test-dns-cares-domains needs a working internet connection
to function (or a local DNS resolver that returns an answer quickly),
otherwise it times out. Move it to test/internet.
PR-URL: #5905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

landed in de92a66

@jasnelljasnell closed this Mar 26, 2016
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
parallel/test-dns-cares-domains needs a working internet connection
to function (or a local DNS resolver that returns an answer quickly),
otherwise it times out. Move it to test/internet.
PR-URL: #5905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucasevanlucas mentioned this pull request Mar 31, 2016
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
parallel/test-dns-cares-domains needs a working internet connection
to function (or a local DNS resolver that returns an answer quickly),
otherwise it times out. Move it to test/internet.
PR-URL: #5905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 9, 2016
parallel/test-dns-cares-domains needs a working internet connection
to function (or a local DNS resolver that returns an answer quickly),
otherwise it times out. Move it to test/internet.
PR-URL: #5905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 11, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dnsIssues and PRs related to the dns subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bnoordhuis@cjihrig@jasnell@mscdex@MylesBorins