Skip to content

[v22.x backport] doc: add missing section for setReturnArrays in sqlite.md - #59099

Merged
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
geeksilva97:backport-add-missing-documentation
Aug 21, 2025
Merged

[v22.x backport] doc: add missing section for setReturnArrays in sqlite.md#59099
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
geeksilva97:backport-add-missing-documentation

Conversation

@geeksilva97

@geeksilva97geeksilva97 commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

This PR is a manual backport of #59074. It adds a missing documentation.

Release reference: #58388

@geeksilva97
geeksilva97 requested a review from a team as a code ownerJuly 17, 2025 02:37
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/releasers
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 17, 2025
@geeksilva97
geeksilva97 changed the base branch from main to v22.x-stagingJuly 17, 2025 02:37
geeksilva97
geeksilva97 commented Jul 17, 2025
View reviewed changes
Comment threaddoc/api/sqlite.md Outdated
@geeksilva97geeksilva97 changed the title Backport add missing documentation[backport] sqlite,doc: add setReturnArrays missing docsJul 17, 2025
@geeksilva97geeksilva97 added doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem. and removed meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 17, 2025
@aduh95aduh95 changed the title [backport] sqlite,doc: add setReturnArrays missing docs[v22.x backport] sqlite,doc: add setReturnArrays missing docsJul 17, 2025
RafaelGSS
RafaelGSS reviewed Jul 17, 2025
View reviewed changes
Comment threaddoc/api/sqlite.md Outdated
@aduh95

aduh95 commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Can you please use the same commit message as ee1ec50?

@geeksilva97

geeksilva97 commented Jul 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Can you please use the same commit message as ee1ec50?

yeas, will do rn

@geeksilva97
geeksilva97force-pushed the backport-add-missing-documentation branch from c50c5d8 to 4af2a6bCompareJuly 17, 2025 16:16
@geeksilva97geeksilva97 changed the title [v22.x backport] sqlite,doc: add setReturnArrays missing docs[v22.x backport] doc: add missing section for setReturnArrays in sqlite.mdJul 17, 2025
@geeksilva97

geeksilva97 commented Jul 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Done @aduh95

@aduh95

aduh95 commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

It's a different message, it's still missing all the commit metadata. Let me take care of that for you

@geeksilva97

geeksilva97 commented Jul 17, 2025

Copy link
Copy Markdown
ContributorAuthor

It's a different message, it's still missing all the commit metadata. Let me take care of that for you

thank you

@geeksilva97@aduh95
doc: add missing section for setReturnArrays in sqlite.md
8eaa19a
PR-URL: nodejs#59074
Refs: nodejs#57542
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
aduh95force-pushed the backport-add-missing-documentation branch from 4af2a6b to 8eaa19aCompareJuly 17, 2025 16:28
@RafaelGSSRafaelGSS added the v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. label Jul 17, 2025
@aduh95
aduh95 merged this pull request into nodejs:v22.x-stagingAug 21, 2025
18 checks passed
@aduh95

aduh95 commented Aug 21, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 997171d3dc9b1376c7557edacbcb6c72b23d035cf7924a1

aduh95 pushed a commit that referenced this pull request Aug 21, 2025
@geeksilva97@aduh95
doc: add missing section for setReturnArrays in sqlite.md
f7924a1
PR-URL: #59074
Backport-PR-URL: #59099
Refs: #57542
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2025
@geeksilva97@aduh95
doc: add missing section for setReturnArrays in sqlite.md
343dbc8
PR-URL: #59074
Backport-PR-URL: #59099
Refs: #57542
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 26, 2025
@geeksilva97@aduh95
doc: add missing section for setReturnArrays in sqlite.md
e22aeaa
PR-URL: #59074
Backport-PR-URL: #59099
Refs: #57542
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.sqliteIssues and PRs related to the SQLite subsystem.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geeksilva97@nodejs-github-bot@aduh95@RafaelGSS