[v22.x backport] Wasm ESM Integration PRs & Unflagging by guybedford · Pull Request #59179 · nodejs/node

guybedford · 2025-07-22T21:41:59Z

Backports:

This does not include source phase imports support as this was a later v8 feature.

This only reflects the unflagging of the experimental instance phase, and the backport is updated to reflect that.

JS String Builtins is possible to support with a very small polyfill layer allowing the implementation to match and pass the tests from v24.

nodejs-github-bot · 2025-07-22T21:42:03Z

Review requested:

@nodejs/config
@nodejs/loaders

nodejs-github-bot · 2025-07-25T16:31:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68198/

ryanaslett · 2025-07-25T16:32:24Z

This is the first PR to run after re-enabling OSX testing.

aduh95 · 2025-07-28T06:30:56Z

Could you please rebase? Also, #59020 is labeled dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x. , do we actually want to include it?

guybedford · 2025-07-28T19:57:56Z

@aduh95 sure, this is now rebased. I initially added that label when I thought string builtins was not implementable, but it was trivial to include the polyfill. Aligning the semantics for instances between 22 and 24 feels like a win to me here, so I think it could be worthwhile.

guybedford · 2025-07-30T02:01:58Z

It actually turns out we can use the V8 flag here instead of including the polyfill for string builtins, so rebasing #59020 was actually much easier than I originally implemented too.

nodejs-github-bot · 2025-08-03T23:43:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68388/

PR-URL: nodejs#59020 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: nodejs#57038 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot · 2025-08-06T18:17:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68444/

nodejs-github-bot · 2025-08-21T13:08:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68786/

nodejs-github-bot · 2025-08-21T15:24:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68792/

nodejs-github-bot · 2025-08-21T17:14:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68795/

nodejs-github-bot · 2025-08-21T19:23:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68800/

nodejs-github-bot · 2025-08-21T20:04:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68801/

nodejs-github-bot · 2025-08-22T00:36:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68808/

nodejs-github-bot · 2025-08-22T08:08:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68813/

nodejs-github-bot · 2025-08-22T08:46:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68815/

nodejs-github-bot · 2025-08-22T10:27:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68816/

nodejs-github-bot · 2025-08-22T12:19:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68818/

nodejs-github-bot · 2025-08-25T18:07:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68866/

nodejs-github-bot · 2025-08-26T09:23:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68869/

nodejs-github-bot · 2025-08-26T14:56:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68880/

nodejs-github-bot · 2025-08-26T16:24:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68882/

nodejs-github-bot · 2025-08-26T17:10:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68885/

nodejs-github-bot · 2025-08-26T22:06:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68895/

PR-URL: #59020 Backport-PR-URL: #59179 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #57038 Backport-PR-URL: #59179 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

aduh95 · 2025-08-26T22:56:48Z

Landed in f64f5df...fa9a9e9

nodejs/node#59179

* chore: bump node in DEPS to v22.19.0 * chore: fixup patch indices * crypto: add tls.setDefaultCACertificates() nodejs/node#58822 * esm: js-string Wasm builtins in ESM Integration nodejs/node#59179 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

guybedford force-pushed the esm-integration-unflag-backport branch from b6d4790 to 8a5a312Compare July 23, 2025 18:52

guybedford changed the title ~~[v22.x backport] esm: unflag --experimental-wasm-modules~~[v22.x backport] Wasm ESM Integration PRs & UnflaggingJul 23, 2025

guybedford force-pushed the esm-integration-unflag-backport branch from 8a5a312 to d069903Compare July 23, 2025 21:16

aduh95 force-pushed the v22.x-staging branch from 3c7a39b to f981495Compare July 24, 2025 18:09

guybedford force-pushed the esm-integration-unflag-backport branch from d069903 to d5ff7eaCompare July 25, 2025 16:25

aduh95 force-pushed the v22.x-staging branch from f981495 to 1e373a0Compare July 27, 2025 18:28

guybedford force-pushed the esm-integration-unflag-backport branch from d5ff7ea to fc09828Compare July 28, 2025 19:56

guybedford force-pushed the esm-integration-unflag-backport branch from fc09828 to cb08197Compare July 30, 2025 02:01

guybedford force-pushed the esm-integration-unflag-backport branch from cb08197 to c25ba79Compare July 30, 2025 02:04

This comment was marked as outdated.
Sign in to view

guybedford force-pushed the esm-integration-unflag-backport branch from c25ba79 to 208e26dCompare July 30, 2025 03:55

This comment was marked as outdated.
Sign in to view

guybedford force-pushed the esm-integration-unflag-backport branch from 208e26d to a9736daCompare August 5, 2025 18:08

esm: js-string Wasm builtins in ESM Integration
dcbda7e
PR-URL: nodejs#59020 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

guybedford force-pushed the esm-integration-unflag-backport branch 2 times, most recently from b2ebc0d to d6de6cdCompare August 6, 2025 00:46

guybedford force-pushed the esm-integration-unflag-backport branch from d6de6cd to 6f42a72Compare August 6, 2025 01:43

aduh95 force-pushed the v22.x-staging branch from 1a95c42 to 6bb153bCompare August 25, 2025 18:07

aduh95 force-pushed the v22.x-staging branch from 6bb153b to f64f5dfCompare August 26, 2025 09:22

aduh95 approved these changes Aug 26, 2025
View reviewed changes

aduh95 closed this Aug 26, 2025

codebytere added a commit to electron/electron that referenced this pull request Sep 5, 2025
esm: js-string Wasm builtins in ESM Integration
23e7793
nodejs/node#59179

Uh oh!

Uh oh!

Conversation

guybedford commented Jul 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 22, 2025

Uh oh!

nodejs-github-bot commented Jul 25, 2025

Uh oh!

ryanaslett commented Jul 25, 2025

Uh oh!

aduh95 commented Jul 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guybedford commented Jul 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guybedford commented Jul 30, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 3, 2025

Uh oh!

nodejs-github-bot commented Aug 6, 2025

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

nodejs-github-bot commented Aug 21, 2025

Uh oh!

nodejs-github-bot commented Aug 22, 2025

Uh oh!

nodejs-github-bot commented Aug 22, 2025

Uh oh!

nodejs-github-bot commented Aug 22, 2025

Uh oh!

nodejs-github-bot commented Aug 22, 2025

Uh oh!

nodejs-github-bot commented Aug 22, 2025

Uh oh!

nodejs-github-bot commented Aug 25, 2025

Uh oh!

nodejs-github-bot commented Aug 26, 2025

Uh oh!

nodejs-github-bot commented Aug 26, 2025

Uh oh!

nodejs-github-bot commented Aug 26, 2025

Uh oh!

nodejs-github-bot commented Aug 26, 2025

Uh oh!

nodejs-github-bot commented Aug 26, 2025

Uh oh!

aduh95 commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guybedford commented Jul 22, 2025•
edited
Loading

aduh95 commented Jul 28, 2025•
edited
Loading

guybedford commented Jul 28, 2025•
edited
Loading