Uh oh!
There was an error while loading. Please reload this page.
test: add known_issues test for GH-2148 - #5920
Conversation
There was a problem hiding this comment.
Won't this technically be + 2 on Windows?
There was a problem hiding this comment.
Probably. Good point. Maybe the thing to do is compare stdout.trim().length in the assertion so as to avoid any assumptions whatsoever about the line separator?
There was a problem hiding this comment.
Yeah, and we may want to compare the (trimmed) output instead of comparing the lengths just to be extra sure we get what we expect.
| } | ||
| const stdout = execSync(`${process.execPath} ${__filename} child`) | ||
| .toString() |
There was a problem hiding this comment.
nit: maybe these would look a little less oddly placed if they were lined up with the first e in execSync()?
There was a problem hiding this comment.
Maybe just do this?
const argv = `${process.execPath} ${__filename} child`
mscdex
commented
Mar 28, 2016
One nit but otherwise LGTM. |
Trott
commented
Mar 30, 2016
PR-URL: nodejs#5920 Refs: nodejs#2148 Reviewed-By: Brian White <mscdex@mscdex.net>
Trott
commented
Mar 31, 2016
Landed in 33c27f8 |
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test, process
Description of change
test: add known_issues test for GH-2148
Refs: #2148