Uh oh!
There was an error while loading. Please reload this page.
doc(test): add missing passed and error on TextContext - #59322
Closed
SimonSchick wants to merge 5 commits into
Closed
doc(test): add missing passed and error on TextContext#59322SimonSchick wants to merge 5 commits into
passed and error on TextContext#59322SimonSchick wants to merge 5 commits into
Conversation
nodejs-github-bot
commented
Aug 1, 2025
Collaborator
Review requested:
|
passed and error on TextContextpassed and error on TextContextpassed and error on TextContextSimonSchickforce-pushed
the
docs/missing-test-context-properties
branch
from
August 1, 2025 21:34
485f8ca to
24c4abcCompareSimonSchickforce-pushed
the
docs/missing-test-context-properties
branch
from
August 1, 2025 21:36
24c4abc to
7ddb4dcCompare
JakobJingleheimer
left a comment
Member
There was a problem hiding this comment.
Thanks for raising.
I wasn't aware of this functionality; I'll check the implementation this weekend to confirm.
Uh oh!
There was an error while loading. Please reload this page.
…rties on TextContext
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…r properties on TextContext
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
8 tasks
aduh95
reviewed
Aug 27, 2025
| ### `context.passed` {boolean} | ||
| <!-- YAML | ||
| added: v20.12.0 |
Contributor
There was a problem hiding this comment.
According to the PR you linked
Suggested change
| added: v20.12.0 | |
| added: | |
| - v21.7.0 | |
| - v20.12.0 |
Member
There was a problem hiding this comment.
@aduh95 should we land it as is and have a follow-up PR? This seems to already improve the situation over what we have right now.
aduh95
reviewed
Aug 27, 2025
| ### `context.error` {Error|null} | ||
| <!-- YAML | ||
| added: v20.12.0 |
Contributor
There was a problem hiding this comment.
Same here I reckon
Suggested change
| added: v20.12.0 | |
| added: | |
| - v21.7.0 | |
| - v20.12.0 |
aduh95
reviewed
Aug 27, 2025
| added: v20.12.0 | ||
| --> | ||
| The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| The failure reason for the test/case; if anything other than an instance of `Error` was thrown, that will be wrapped | |
| The failure reason for the test/case; if anything other than an instance of {Error} was thrown, that will be wrapped |
MoLow
approved these changes
Aug 27, 2025
Xstoudi added a commit
to Xstoudi/node
that referenced
this pull request
Dec 28, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: nodejs#59321 Refs: nodejs#51485 Refs: nodejs#59322 Co-authored-by: SimonSchick <demwizzy@gmail.com>
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 30, 2025
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jan 9, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jan 12, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jan 13, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jan 19, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Feb 17, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Feb 19, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Feb 21, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Feb 23, 2026
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: #59321 Refs: #51485 Refs: #59322 Co-authored-by: SimonSchick <demwizzy@gmail.com> PR-URL: #61185 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #59321 and #51485 for implementation