Uh oh!
There was an error while loading. Please reload this page.
build: fix OpenSSL version detection - #59353
Merged
Merged
Conversation
Fix OpenSSL version detection in `configure.py` when `pkg-config` is used to configure building with a shared OpenSSL library.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Aug 4, 2025
Collaborator
panva
approved these changes
Aug 4, 2025
lpinca
approved these changes
Aug 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Aug 6, 2025
Collaborator
Landed in 2b4a09e |
mete0rfish pushed a commit
to mete0rfish/node-contribute
that referenced
this pull request
Aug 9, 2025
Fix OpenSSL version detection in `configure.py` when `pkg-config` is used to configure building with a shared OpenSSL library. PR-URL: nodejs#59353 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OpenSSL version detection in
configure.pywhenpkg-configis used to configure building with a shared OpenSSL library.Fixes: #59249 (comment)
cc @jasnell