test: fix hidden error in test-http-server-stale-close.js by nektro · Pull Request #59357 · nodejs/node

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nektro · 2025-08-05T04:19:27Z

before:

❯ node test/parallel/test-http-server-stale-close.js
node:internal/errors:540
throw error;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of IncomingMessage
at process.set [as exitCode] (node:internal/bootstrap/node:119:9)
at ClientRequest.exit (node:internal/process/per_thread:231:24)
at Object.onceWrapper (node:events:622:26)
at ClientRequest.emit (node:events:507:28)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:716:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
at Socket.socketOnData (node:_http_client:558:22)
at Socket.emit (node:events:507:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3) {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v24.3.0
❯ echo $?
0

after:

❯ node test/parallel/test-http-server-stale-close.js

codecov · 2025-08-05T05:09:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (dfee0b1) to head (7944416).
⚠️ Report is 2753 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59357 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.03% 
==========================================
Files 656 656 Lines 193141 193141 Branches 37886 37888 +2 ==========================================
- Hits 173623 173568 -55 - Misses 12051 12099 +48 - Partials 7467 7474 +7

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu · 2025-08-09T02:57:12Z

@nektro
Could you please rebase the main branch?
I think it will fix the Windows error.

nodejs-github-bot · 2025-08-09T03:33:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68508/

nodejs-github-bot · 2025-08-10T10:12:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68532/

nodejs-github-bot · 2025-08-10T13:43:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68534/

nodejs-github-bot · 2025-08-11T05:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/68552/

nodejs-github-bot · 2025-08-12T00:50:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/59357
✔ Done loading data for nodejs/node/pull/59357
----------------------------------- PR info ------------------------------------
Title test: fix hidden error in test-http-server-stale-close.js (#59357)
Author Meghan Denny <hello@nektro.net> (@nektro)
Branch nektro:patch-9 -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 2
- test: fix hidden error in test-http-server-stale-close.js
- Merge branch 'main' into patch-9
Committers 1
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59357
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 05 Aug 2025 04:19:27 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59357#pullrequestreview-3089680106
✔ - Ryuhei Shima (@islandryu): https://github.com/nodejs/node/pull/59357#pullrequestreview-3102466424
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/59357#pullrequestreview-3104630403
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-08-11T05:37:20Z: https://ci.nodejs.org/job/node-test-pull-request/68552/
- Querying data for job/node-test-pull-request/68552/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 59357
From https://github.com/nodejs/node
* branch refs/pull/59357/merge -> FETCH_HEAD
✔ Fetched commits as fc3f19ef9324..24465b0ec1f8
--------------------------------------------------------------------------------
error: commit 24465b0ec1f8fafa4bd4b72b0335bed602e5203e is a merge but no -m option was given.
fatal: cherry-pick failed
[main 02dc17085b] test: fix hidden error in test-http-server-stale-close.js
Author: Meghan Denny <meghan@bun.sh>
Date: Mon Aug 4 21:17:59 2025 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/16895898564

islandryu · 2025-08-12T01:22:16Z

@nektro
Sorry, you might have done a merge pull.
Could you remove the merge commit and pull main using rebase instead?
https://github.com/islandryu/node/blob/59112/doc/contributing/pull-requests.md#step-9-discuss-and-update

aduh95 · 2025-08-27T10:53:23Z

Could we update the test to make it fail if the forked child process exits with non-zero code?

constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200,{'Content-Length': '42'});req.pipe(res);assert.strictEqual(req.destroyed,false);req.on('close',common.mustCall(()=>{assert.strictEqual(req.destroyed,true);server.close();res.end();}));}));server.listen(0,common.mustCall(function(){constcp=fork(__filename,{stdio: 'inherit',env: { ...process.env,NODE_TEST_FORK_PORT: this.address().port}});cp.once('exit',common.mustCall((code)=>{assert.strictEqual(code,0);}))}));

github-actions · 2026-07-28T00:22:43Z

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

aduh95 · 2026-08-10T15:51:42Z

Landed in 536aca7

PR-URL: #59357 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 5, 2025

lpinca approved these changes Aug 5, 2025
View reviewed changes

islandryu approved these changes Aug 6, 2025
View reviewed changes

islandryu self-requested a review August 9, 2025 03:04

islandryu approved these changes Aug 9, 2025
View reviewed changes

islandryu added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2025

gurgunday approved these changes Aug 10, 2025
View reviewed changes

gurgunday added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 10, 2025

StefanStojanovic approved these changes Aug 11, 2025
View reviewed changes

islandryu added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 12, 2025

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 12, 2025

test: fix hidden error in test-http-server-stale-close.js
7944416

nektro force-pushed the patch-9 branch from 24465b0 to 7944416Compare August 19, 2025 06:54

github-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026

aduh95 merged commit 536aca7 into nodejs:mainAug 10, 2026
20 checks passed

aduh95 mentioned this pull request Aug 10, 2026
test: enforce exit code in test-http-server-stale-close#65198
Merged

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged