Skip to content

build: only mention Apple when on Apple - #59385

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:apple
Aug 9, 2025
Merged

build: only mention Apple when on Apple#59385
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:apple

Conversation

@targos

@targostargos commented Aug 7, 2025

Copy link
Copy Markdown
Member

No description provided.

@targostargos added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 7, 2025
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 7, 2025
@targostargos mentioned this pull request Aug 7, 2025
Closed
@targostargos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 7, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2025
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68465/

@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68483/

@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68487/

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 8, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 7079041 into nodejs:mainAug 9, 2025
82 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in 7079041

@RafaelGSSRafaelGSS mentioned this pull request Oct 9, 2025
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@richardlaurichardlaurichardlau approved these changes
@legendecaslegendecaslegendecas approved these changes
@jakecastellijakecastellijakecastelli approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@nodejs-github-bot@lpinca@UlisesGascon@richardlau@legendecas@jakecastelli