Uh oh!
There was an error while loading. Please reload this page.
test: add file attribute to JUnit reporter testcase elements - #59432
test: add file attribute to JUnit reporter testcase elements#59432Han5991 wants to merge 2 commits into
Conversation
nodejs-github-bot
commented
Aug 10, 2025
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #59432 +/- ##
=======================================
Coverage 88.53% 88.54% =======================================
Files 703 703 Lines 207804 207807 +3 Branches 40005 40005 =======================================
+ Hits 183989 184005 +16 + Misses 15817 15811 -6 + Partials 7998 7991 -7
🚀 New features to boost your workflow:
|
791f5f7 to
2473640CompareHan5991
commented
Aug 11, 2025
Force pushed to fix commit message lint error - shortened title to meet 72 character limit per Node.js contribution guidelines. |
2473640 to
70e2c68CompareHan5991
commented
Aug 18, 2025
Force pushed to fix commit message lint error - shortened title to meet 72 character limit per Node.js contribution guidelines. |
@Han5991 Thanks for the contribution! |
70e2c68 to
fa35503CompareHan5991
commented
Aug 18, 2025
Thank you! The submodule reference has been successfully changed from "test" to "test_runner" in the second commit message. |
atlowChemi
commented
Aug 18, 2025
They seem to be applied the wrong way? |
fa35503 to
25aeae1CompareHan5991
commented
Aug 18, 2025
@atlowChemi |
nodejs-github-bot
commented
Aug 18, 2025
nodejs-github-bot
commented
Sep 17, 2025
Han5991
commented
Sep 17, 2025
One of the CI jobs seems to have failed due to a flaky test. Would you mind rerunning just the failed job when you have a chance? |
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter.
Add file attribute to JUnit testcase elements when file information is available in test event data.
25aeae1 to
6509a5eComparenodejs-github-bot
commented
Oct 8, 2025
nodejs-github-bot
commented
Oct 8, 2025
nodejs-github-bot
commented
Oct 8, 2025
nodejs-github-bot
commented
Oct 8, 2025
nodejs-github-bot
commented
Oct 8, 2025
Landed in 1527825...f0aa073 |
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter. PR-URL: #59432Fixes: #59422 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter. PR-URL: #59432Fixes: #59422 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter. PR-URL: #59432Fixes: #59422 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Fixes: #59422
This PR adds support for the
fileattribute in JUnit XML reporter'stestcaseelements, addressing the missing source file information that is useful for CI/CD platformslike GitLab.
Changes
fileattribute support in JUnit reporter for testcase elementsBackground
The JUnit XML specification supports a
fileattribute ontestcaseelements to indicate the source file containing the test. This attribute was missing from Node.js testrunner's JUnit output, limiting integration with tools that rely on this information for enhanced test reporting.
Before:
Testing
