Uh oh!
There was an error while loading. Please reload this page.
benchmark: update num to n in dgram offset-length - #59708
Conversation
nodejs-github-bot
commented
Sep 1, 2025
Review requested:
|
RafaelGSS
commented
Sep 1, 2025
+1 |
brunocroh
commented
Sep 3, 2025
done |
RafaelGSS
commented
Sep 3, 2025
@brunocroh can you make sure to update the spreadsheet with the PRs you did? Also, let's focus just on benchmarks that take more than 10 min (on compare.js) to conclude |
brunocroh
commented
Sep 4, 2025
Yes, sure. Since I don’t have permission to edit the table, I just added comments with the PR URL. Regarding the duration, I’m trying to focus on the ones that take longer to execute. At the same time, I’m also updating the ones that don’t support the N flag because of the requirements in nodejs/performance#187. |
nodejs-github-bot
commented
Sep 14, 2025
nodejs-github-bot
commented
Sep 24, 2025
Landed in e4e86ea...6ce89d7 |
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Replace the
numconfig withnto be compatible with thenCLI argument.Since this benchmark doesn’t take too long to run (about 40s), I didn’t change the config.
I ran the benchmarks for comparison, but I’m not sure if using len as [1, 512, 1024] would provide better coverage than [1, 64, 256, 1024]. What do you guys think?
If that makes sense to you, let me know, and I can update it to
[1, 512, 1024].This change reduces the execution time from 40s to 30s.
Here’s the output for both configs:
len: [1, 64, 256, 1024]
len: [1,512,1024]
Benchmark Machine Specifications: