Uh oh!
There was an error while loading. Please reload this page.
module: fix directory option in the enableCompileCache() API - #59931
Merged
Conversation
nodejs-github-bot
commented
Sep 18, 2025
Collaborator
Review requested:
|
joyeecheungforce-pushed
the
fix-compile-cache-api
branch
from
September 18, 2025 21:49
a2251fa to
8fa6d26CompareThe option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it.
joyeecheungforce-pushed
the
fix-compile-cache-api
branch
from
September 18, 2025 21:57
8fa6d26 to
9fe76e8CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #59931 +/- ##
==========================================
+ Coverage 88.23% 88.48% +0.24%
==========================================
Files 703 703 Lines 207393 207550 +157 Branches 39888 40013 +125 ==========================================
+ Hits 183003 183645 +642 + Misses 16346 15900 -446 + Partials 8044 8005 -39
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Aditi <62544124+Aditi-1400@users.noreply.github.com>
nodejs-github-bot
commented
Sep 22, 2025
Collaborator
nodejs-github-bot
commented
Sep 23, 2025
Collaborator
jsumners-nr
approved these changes
Sep 24, 2025
nodejs-github-bot
commented
Sep 29, 2025
Collaborator
nodejs-github-bot
commented
Oct 8, 2025
Collaborator
nodejs-github-bot
commented
Oct 8, 2025
Collaborator
Aditi-1400
approved these changes
Oct 9, 2025
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Oct 9, 2025
Collaborator
Landed in db0121b |
9 tasks
aduh95 pushed a commit
that referenced
this pull request
Oct 31, 2025
The option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it. PR-URL: #59931 Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 18, 2025
The option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it. PR-URL: #59931 Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option name should be
directoryto be consistent with the returned result. It should also allow environment variable overrides.This also adds documentation for the new options and improves it.