Uh oh!
There was an error while loading. Please reload this page.
https: optimize session cache property access - #59967
Closed
jbj338033 wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Sep 22, 2025
Collaborator
Review requested:
|
mcollina
left a comment
Member
There was a problem hiding this comment.
Does this actually improve performance?
| }; | ||
| Agent.prototype._evictSession = function _evictSession(key) { | ||
| const index = ArrayPrototypeIndexOf(this._sessionCache.list, key); | ||
| const { map, list } = this._sessionCache; |
Member
There was a problem hiding this comment.
There is no need to optimize map, as it's only used once. I would also avoid destructuring.
| @@ -572,30 +572,34 @@ Agent.prototype._cacheSession = function _cacheSession(key, session) { | |||
| if (this.maxCachedSessions === 0) | |||
| return; | |||
| // Cache property accesses for better performance | |||
| const { map, list } = this._sessionCache; | |||
Member
There was a problem hiding this comment.
I would avoid destructuring and just extract map here, and then list just before its used.
4 tasks
Cache frequently accessed properties in _cacheSession and _evictSession methods to improve performance. This reduces the number of property lookups in hot paths of HTTPS session caching. Changes: - _cacheSession: Cache map and list properties separately, avoiding destructuring as suggested in review - _evictSession: Only cache list property since map is accessed once The optimization follows a similar pattern to other performance improvements in the codebase by caching frequently accessed object properties in local variables. Benchmark results show 12-18% improvement in session cache operations: https/https-session-cache.js n=10000 sessions=100: 18.2% improvement https/https-session-cache.js n=10000 sessions=256: 12.7% improvement Signed-off-by: jbj338033 <jbj338033@gmail.com>
jbj338033force-pushed
the
perf/zlib-buffer-optimization
branch
from
September 22, 2025 12:32
afb6802 to
bd8ffe3Comparemcollina
commented
Sep 22, 2025
Member
What does the benchmark before/after reports? |
jbj338033
commented
Sep 22, 2025
Author
The benchmark results show inconsistent performance with regressions in several cases, so this optimization isn't worth merging. I'll close this PR and look for better opportunities. Appreciate the feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #59967 +/- ##
=======================================
Coverage 88.41% 88.42% =======================================
Files 703 703 Lines 207421 207426 +5 Branches 39993 40005 +12 =======================================
+ Hits 183398 183423 +25 + Misses 15996 15985 -11 + Partials 8027 8018 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_cacheSessionand from 2 to 1 in_evictSessionDetails
This PR improves the performance of HTTPS session caching by caching the
this._sessionCache.mapandthis._sessionCache.listproperty accesses in local variables. This pattern is commonly used throughout the Node.js codebase to reduce repeated object property lookups.The optimization is particularly beneficial in high-throughput HTTPS scenarios where session caching is frequently accessed.
Performance Impact
Test plan