Uh oh!
There was an error while loading. Please reload this page.
test: verify tracing channel doesn't swallow unhandledRejection - #59974
Merged
Conversation
Add a test to verify that TracingChannel.tracePromise doesn't swallow unhandledRejection events in case no then/catch handler is set by user.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #59974 +/- ##
=======================================
Coverage 88.42% 88.43% =======================================
Files 703 703 Lines 207413 207413 Branches 40007 40004 -3 =======================================
+ Hits 183398 183418 +20 + Misses 15992 15973 -19 + Partials 8023 8022 -1 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Sep 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
approved these changes
Sep 23, 2025
nodejs-github-bot
commented
Sep 23, 2025
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Sep 24, 2025
Collaborator
Landed in 4dc19ec |
targos pushed a commit
that referenced
this pull request
Oct 6, 2025
Add a test to verify that TracingChannel.tracePromise doesn't swallow unhandledRejection events in case no then/catch handler is set by user. PR-URL: #59974 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Oct 22, 2025
Add a test to verify that TracingChannel.tracePromise doesn't swallow unhandledRejection events in case no then/catch handler is set by user. PR-URL: #59974 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to verify that
TracingChannel.tracePromisedoesn't swallowunhandledRejectionevents in case no then/catch handler is set by user.Refs: #59944 (comment)