Uh oh!
There was an error while loading. Please reload this page.
test: fix typo of test-benchmark-readline.js - #59993
Closed
deokjinkim wants to merge 1 commit into
Closed
Conversation
"bechmark" -> "benchmark" in test-benchmark-readline.js. And fix test name in test-benchmark-validators.js.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #59993 +/- ##
==========================================
- Coverage 88.45% 88.42% -0.03%
==========================================
Files 703 703 Lines 207545 207545 Branches 40013 40010 -3 ==========================================
- Hits 183578 183528 -50 - Misses 15957 16004 +47 - Partials 8010 8013 +3 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Sep 23, 2025
nodejs-github-bot
commented
Sep 23, 2025
Collaborator
nodejs-github-bot
commented
Sep 23, 2025
Collaborator
nodejs-github-bot
commented
Sep 24, 2025
Collaborator
nodejs-github-bot
commented
Sep 24, 2025
Collaborator
daeyeon
approved these changes
Sep 25, 2025
nodejs-github-bot
commented
Sep 25, 2025
Collaborator
UlisesGascon
approved these changes
Sep 25, 2025
nodejs-github-bot
commented
Sep 25, 2025
Collaborator
Member
Landed in b51fd73 |
addaleax pushed a commit
that referenced
this pull request
Sep 30, 2025
"bechmark" -> "benchmark" in test-benchmark-readline.js. And fix test name in test-benchmark-validators.js. PR-URL: #59993 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
targos pushed a commit
that referenced
this pull request
Oct 6, 2025
"bechmark" -> "benchmark" in test-benchmark-readline.js. And fix test name in test-benchmark-validators.js. PR-URL: #59993 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Oct 22, 2025
"bechmark" -> "benchmark" in test-benchmark-readline.js. And fix test name in test-benchmark-validators.js. PR-URL: #59993 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Nov 19, 2025
"bechmark" -> "benchmark" in test-benchmark-readline.js. And fix test name in test-benchmark-validators.js. PR-URL: #59993 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"bechmark" -> "benchmark" in test-benchmark-readline.js. And fix test name in test-benchmark-validators.js.