Skip to content

test: replace diagnostics_channel stackframe in output snapshots - #60024

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:source-map-snapshot
Oct 3, 2025
Merged

test: replace diagnostics_channel stackframe in output snapshots#60024
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:source-map-snapshot

Conversation

@legendecas

@legendecaslegendecas commented Sep 26, 2025

Copy link
Copy Markdown
Member

This prevent changes in lib/diagnostics_channel.js impact test output snapshots.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 26, 2025
cjihrig
cjihrig reviewed Sep 26, 2025
View reviewed changes
Comment threadtest/common/assertSnapshot.js Outdated
@legendecas

legendecas commented Sep 26, 2025

Copy link
Copy Markdown
MemberAuthor

Simplied the merged regex.

@codecov

codecovBot commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (4dc19ec) to head (412d7df).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60024 +/- ##
==========================================
- Coverage 88.49% 88.46% -0.03% 
==========================================
Files 703 703 Lines 207529 207546 +17 Branches 40011 40015 +4 ==========================================
- Hits 183643 183609 -34 - Misses 15885 15938 +53 + Partials 8001 7999 -2

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69388/

@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69449/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69498/

@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69506/

@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69515/

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2025
@nodejs-github-bot
nodejs-github-bot merged commit ffb25b8 into nodejs:mainOct 3, 2025
60 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Landed in ffb25b8

@legendecas
legendecas deleted the source-map-snapshot branch October 4, 2025 07:28
targos pushed a commit that referenced this pull request Oct 6, 2025
@legendecas@targos
test: replace diagnostics_channel stackframe in output snapshots
5538cfc
PR-URL: #60024
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
@legendecas@aduh95
test: replace diagnostics_channel stackframe in output snapshots
e4b95a5
PR-URL: #60024
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 23, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@lpinca@cjihrig