Skip to content

src,sqlite: replace tolocalchecked with tolocal - #60028

Closed
geeksilva97 wants to merge 3 commits into
nodejs:mainfrom
geeksilva97:fix-filter-function-crashing
Closed

src,sqlite: replace tolocalchecked with tolocal#60028
geeksilva97 wants to merge 3 commits into
nodejs:mainfrom
geeksilva97:fix-filter-function-crashing

Conversation

@geeksilva97

@geeksilva97geeksilva97 commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

This PR replaces ToLocalChecked with ToLocal in multiple places so we prevent unexpected crashes.

@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 26, 2025
@addaleaxaddaleax mentioned this pull request Sep 26, 2025
Closed
addaleax
addaleax approved these changes Sep 26, 2025
View reviewed changes
Comment threadsrc/node_sqlite.cc Outdated
Comment threadsrc/node_sqlite.cc
Comment threadsrc/node_sqlite.cc Outdated
@codecov

codecovBot commented Sep 26, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.47%. Comparing base (3312e4e) to head (1490d09).
⚠️ Report is 22 commits behind head on main.

Files with missing linesPatch %Lines
src/node_sqlite.cc72.22%3 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #60028 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01% 
==========================================
Files 703 703 Lines 207546 207551 +5 Branches 40006 40001 -5 ==========================================
- Hits 183631 183622 -9 - Misses 15907 15912 +5 - Partials 8008 8017 +9
Files with missing linesCoverage Δ
src/node_sqlite.cc79.42% <72.22%> (-0.15%)⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69433/

@geeksilva97geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 28, 2025
louwers
louwers reviewed Sep 28, 2025
View reviewed changes
Comment threadtest/parallel/test-sqlite-session.js Outdated
louwers
louwers reviewed Sep 28, 2025
View reviewed changes

@louwerslouwers left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was still one of the open issues for the session extension integration.

I think this implementation makes it possible that a changeset is being applied partially. Not a big deal, the user could just wrap it in a transaction. Just something to be aware of.

I think we should do a rollback if any exception is being thrown from either the filter callback or the conflict handler before stabilizing the SQLite API. But for now, this is an improvement.

@geeksilva97geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2025
@github-actions

github-actionsBot commented Sep 28, 2025

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ Commits were pushed since the last approving review:
⚠ - src,sqlite: replace tolocalchecked with tolocal
⚠ - src: implement addaleax suggestions
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/18080613898

@geeksilva97geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Sep 29, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69439/

@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69443/

@geeksilva97geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69457/

addaleax pushed a commit that referenced this pull request Sep 30, 2025
@geeksilva97@addaleax
sqlite: replace ToLocalChecked and improve filter error handling
4136934
PR-URL: #60028
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

addaleax commented Sep 30, 2025

Copy link
Copy Markdown
Member

Landed in 4136934

@geeksilva97geeksilva97 mentioned this pull request Sep 30, 2025
Closed
targos pushed a commit that referenced this pull request Oct 6, 2025
@geeksilva97@targos
sqlite: replace ToLocalChecked and improve filter error handling
d949222
PR-URL: #60028
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gurgundaygurgundaygurgunday approved these changes
@addaleaxaddaleaxAwaiting requested review from addaleax
+1 more reviewer
@louwerslouwerslouwers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@geeksilva97@nodejs-github-bot@addaleax@jasnell@louwers@cjihrig@gurgunday