Skip to content

src: update cares_wrap to use DictionaryTemplates - #60033

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/dns-use-dictionarytemplate
Oct 4, 2025
Merged

src: update cares_wrap to use DictionaryTemplates#60033
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/dns-use-dictionarytemplate

Conversation

@jasnell

@jasnelljasnell commented Sep 27, 2025

Copy link
Copy Markdown
Member

Updates cares_wrap to use DictionaryTemplates

@nodejs-github-bot

nodejs-github-bot commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Sep 27, 2025
@jasnell
jasnellforce-pushed the jasnell/dns-use-dictionarytemplate branch from 127af14 to 3be0a50CompareSeptember 27, 2025 19:26
addaleax
addaleax approved these changes Sep 27, 2025
View reviewed changes
Comment threadsrc/cares_wrap.cc Outdated
@codecov

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/dns-use-dictionarytemplate branch from 3be0a50 to a4cca1dCompareSeptember 27, 2025 20:48
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 27, 2025
@github-actions

github-actionsBot commented Sep 27, 2025

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ Commits were pushed since the last approving review:
⚠ - src: update cares_wrap to use DictionaryTemplates
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/18064805920

@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@jasnelljasnell removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Sep 27, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69551/ 💛

@jasnell
jasnell requested a review from anonrigOctober 4, 2025 19:49
@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
@nodejs-github-bot
nodejs-github-bot merged commit e6cd8a2 into nodejs:mainOct 4, 2025
68 of 69 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Landed in e6cd8a2

targos pushed a commit that referenced this pull request Oct 6, 2025
@jasnell@targos
src: update cares_wrap to use DictionaryTemplates
9db54ad
PR-URL: #60033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@anonriganonrigAwaiting requested review from anonrig

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell@nodejs-github-bot@addaleax