Uh oh!
There was an error while loading. Please reload this page.
console,util: improve array inspection performance - #60037
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
There is no need to do the own property check, since the descriptor is needed right afterwards anyway.
BridgeAR
commented
Sep 27, 2025
MemberAuthor
addaleax
approved these changes
Sep 27, 2025
jasnell
approved these changes
Sep 27, 2025
nodejs-github-bot
commented
Sep 27, 2025
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #60037 +/- ##
==========================================
+ Coverage 88.28% 88.47% +0.19%
==========================================
Files 702 703 +1 Lines 206995 207547 +552 Branches 39833 40009 +176 ==========================================
+ Hits 182740 183633 +893 + Misses 16265 15903 -362 - Partials 7990 8011 +21
🚀 New features to boost your workflow:
|
nodejs-github-bot
commented
Sep 28, 2025
Collaborator
cjihrig
approved these changes
Sep 28, 2025
ljharb
approved these changes
Sep 28, 2025
nodejs-github-bot
commented
Sep 29, 2025
Collaborator
gurgunday
approved these changes
Sep 29, 2025
nodejs-github-bot
commented
Sep 29, 2025
Collaborator
addaleax pushed a commit
that referenced
this pull request
Sep 30, 2025
There is no need to do the own property check, since the descriptor is needed right afterwards anyway. PR-URL: #60037 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
addaleax
commented
Sep 30, 2025
Member
Landed in c2536ad |
targos pushed a commit
that referenced
this pull request
Oct 6, 2025
There is no need to do the own property check, since the descriptor is needed right afterwards anyway. PR-URL: #60037 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Oct 22, 2025
There is no need to do the own property check, since the descriptor is needed right afterwards anyway. PR-URL: #60037 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to do the own property check, since the descriptor is needed right afterwards anyway.