Skip to content

deps: update ada to 3.3.0 - #60045

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada
Oct 2, 2025
Merged

deps: update ada to 3.3.0#60045
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 3.3.0.

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Sep 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/security-wg
  • @nodejs/url

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 28, 2025
@aduh95

aduh95 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

This PR doesn't contain any change, which is odd for a semver-minor //cc @anonrig

@lemire

lemire commented Sep 30, 2025

Copy link
Copy Markdown
Member

@aduh95 It is correct. There are several changes but none that should affect Node.js.

See

ada-url/ada@v3.2.9...v3.3.0

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/69492/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/69497/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 5ac8f26 into mainOct 2, 2025
66 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 5ac8f26

@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-ada branch October 2, 2025 13:45
targos pushed a commit that referenced this pull request Oct 6, 2025
@nodejs-github-bot@targos
deps: update ada to 3.3.0
ec0f137
PR-URL: #60045
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
@richardlaurichardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 7, 2025
@github-actionsgithub-actionsBot mentioned this pull request Jan 3, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency file.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nodejs-github-bot@aduh95@lemire@anonrig@UlisesGascon@richardlau