Skip to content

src: remove unused variables from report - #60047

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
iknoom:remove-unused-variable
Oct 2, 2025
Merged

src: remove unused variables from report#60047
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
iknoom:remove-unused-variable

Conversation

@iknoom

@iknoomiknoom commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

This PR removes unused variables in node_report.cc detected by clang-tidy(bugprone-unused-local-non-trivial-variable).

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels Sep 28, 2025
@codecov

codecovBot commented Sep 28, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (cff138c) to head (bb421bb).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60047 +/- ##
=======================================
Coverage 88.45% 88.46% =======================================
Files 703 703 Lines 207546 207544 -2 Branches 40016 40011 -5 =======================================
+ Hits 183595 183598 +3 + Misses 15956 15942 -14 - Partials 7995 8004 +9
Files with missing linesCoverage Δ
src/node_report.cc93.14% <ø> (-0.03%)⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theanarkhtheanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69407/

@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69411/

@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69414/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69459/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69468/

@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69503/

@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 36b1cc2 into nodejs:mainOct 2, 2025
81 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Landed in 36b1cc2

targos pushed a commit that referenced this pull request Oct 6, 2025
@iknoom@targos
src: remove unused variables from report
3e8fdc1
PR-URL: #60047
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
@iknoom@aduh95
src: remove unused variables from report
609c063
PR-URL: #60047
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 23, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@legendecaslegendecaslegendecas approved these changes
@theanarkhtheanarkhtheanarkh approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.reportIssues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iknoom@nodejs-github-bot@addaleax@lpinca@cjihrig@legendecas@theanarkh