Uh oh!
There was an error while loading. Please reload this page.
url: fix format when query is not an object - #6005
Closed
ajafff wants to merge 1 commit into
Closed
Conversation
url.format uses query if search is falsy. Currently query is only used if it is an object. Query will now be inserted if its value is truthy. Fixes: #6004
mscdex
commented
Apr 2, 2016
Contributor
cjihrig
commented
Apr 2, 2016
Contributor
This would require a documentation update. |
| assert(url.format({}) === ''); | ||
| // https://github.com/nodejs/node/issues/6004 | ||
| assert.equal(url.format({pathname:'/foo', query: 'bar=baz'}), '/foo?bar=baz'); |
Contributor
There was a problem hiding this comment.
minor nit: there should be a space after pathname:
benjamingr
commented
Apr 3, 2016
Member
Isn't this a semver major since an error is no longer thrown where an error was thrown before? |
jasnell
commented
Apr 4, 2016
Member
@benjamingr ... I may be missing something but I'm not seeing a change in error handling. @ajafff ... while this is generally ok, I'm curious why not simply use |
estliberitasforce-pushed
the
master
branch
2 times, most recently
from
April 26, 2016 05:23
7da4fd4 to
c7066fbCompare2 tasks
cjihrig
commented
Jun 16, 2016
Contributor
@ajafff are you still planning to work on this? |
rvaggforce-pushed
the
master
branch
2 times, most recently
from
October 18, 2016 17:01
c133999 to
83c7a88Comparejasnell
commented
Mar 1, 2017
Member
Closing given the lack of forward progress on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
url
Description of change
url.format uses query if search is falsy. Currently query is only used
if it is an object. Query will now be inserted if its value is truthy.
Fixes: #6004