Uh oh!
There was an error while loading. Please reload this page.
src: allow std::string_view arguments to SPrintF() and friends - #60058
Closed
addaleax wants to merge 1 commit into
Closed
src: allow std::string_view arguments to SPrintF() and friends#60058addaleax wants to merge 1 commit into
std::string_view arguments to SPrintF() and friends#60058addaleax wants to merge 1 commit into
Conversation
addaleaxforce-pushed
the
sprintf-string-view-format-arg
branch
from
September 28, 2025 12:44
84646ef to
88a83f1CompareModernize the code so there is no need to work with raw C strings anymore.
addaleaxforce-pushed
the
sprintf-string-view-format-arg
branch
from
September 28, 2025 12:48
88a83f1 to
5a68e33Comparejasnell
approved these changes
Sep 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #60058 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 703 703 Lines 207546 207710 +164 Branches 40011 40012 +1 ==========================================
+ Hits 183591 183729 +138 - Misses 15949 15973 +24 - Partials 8006 8008 +2
🚀 New features to boost your workflow:
|
nodejs-github-bot
commented
Sep 28, 2025
Collaborator
juanarbol
approved these changes
Sep 28, 2025
nodejs-github-bot
commented
Sep 28, 2025
Collaborator
legendecas
approved these changes
Sep 29, 2025
addaleax added a commit
that referenced
this pull request
Sep 30, 2025
Modernize the code so there is no need to work with raw C strings anymore. PR-URL: #60058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
addaleax
commented
Sep 30, 2025
MemberAuthor
Landed in 3b0b6b9 |
targos pushed a commit
that referenced
this pull request
Oct 6, 2025
Modernize the code so there is no need to work with raw C strings anymore. PR-URL: #60058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Oct 22, 2025
Modernize the code so there is no need to work with raw C strings anymore. PR-URL: #60058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize the code so there is no need to work with raw C strings anymore.