Skip to content

src: update contextify to use DictionaryTemplate - #60059

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/contextify-dictionarytemplate
Oct 6, 2025
Merged

src: update contextify to use DictionaryTemplate#60059
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/contextify-dictionarytemplate

Conversation

@jasnell

@jasnelljasnell commented Sep 28, 2025

Copy link
Copy Markdown
Member

More use of DictionaryTemplate

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Sep 28, 2025
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@BridgeARBridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 29, 2025
BridgeAR

This comment was marked as resolved.

Sign in to view

legendecas
legendecas reviewed Sep 29, 2025
View reviewed changes
Comment threadsrc/node_contextify.cc Outdated
@jasnell
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from 67a08e7 to 956b245CompareOctober 4, 2025 12:53
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@addaleax

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from 956b245 to fa77052CompareOctober 5, 2025 12:47
@jasnell
jasnell requested a review from BridgeAROctober 5, 2025 12:48
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69570/

@jasnell
jasnell requested a review from addaleaxOctober 5, 2025 12:48
legendecas
legendecas requested changes Oct 5, 2025
View reviewed changes

@legendecaslegendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not convincing that a 20-line if-condition is more readable than simple early returns. I don't believe this beneficial change has to be bundled with a subjective style change.

@jasnell
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from fa77052 to 23601daCompareOctober 5, 2025 22:45
@jasnell
jasnellforce-pushed the jasnell/contextify-dictionarytemplate branch from 23601da to b53b4ecCompareOctober 5, 2025 22:55
@jasnell

jasnell commented Oct 5, 2025

Copy link
Copy Markdown
MemberAuthor

Blocking an otherwise fully correct PR for a purely subjective style change seems more counterproductive, especially when the style change is consistent with lots of other places throughout the codebase, but ok. I switched it back to the multiple separate if statements.

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69576/

legendecas
legendecas approved these changes Oct 6, 2025
View reviewed changes

@legendecaslegendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@addaleaxaddaleax added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 6, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 4a7fbb6 into nodejs:mainOct 6, 2025
60 of 61 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in 4a7fbb6

targos pushed a commit that referenced this pull request Oct 6, 2025
@jasnell@targos
src: update contextify to use DictionaryTemplate
e273c20
PR-URL: #60059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@tniessentniessentniessen approved these changes
@legendecaslegendecaslegendecas approved these changes
@BridgeARBridgeARAwaiting requested review from BridgeAR

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@addaleax@tniessen@legendecas@BridgeAR