Skip to content

doc: update teams in collaborator-guide.md and add links - #60065

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
louwers:patch-1
Oct 11, 2025
Merged

doc: update teams in collaborator-guide.md and add links#60065
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
louwers:patch-1

Conversation

@louwers

@louwerslouwers commented Sep 28, 2025

Copy link
Copy Markdown
Contributor
  • Remove @nodejs/modules, team does not exist
  • Remove @nodejs/util
  • Add @nodejs/sqlite
  • Add links

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 28, 2025
@aduh95

Copy link
Copy Markdown
Contributor

Those links makes the document very hard to read, if we're adding them (and tbh, I'm not sure it's worth it), we would want to add references at the end of the file (i.e. [@nodejs/team][] in the table and [@nodejs/team]: https://… at EOF)

@louwers

Copy link
Copy Markdown
ContributorAuthor

@aduh95 Good call!

@louwers

Copy link
Copy Markdown
ContributorAuthor

@aduh95 Please have another look, thanks!

Comment threaddoc/contributing/collaborator-guide.md Outdated
@louwers

Copy link
Copy Markdown
ContributorAuthor

cc @bnoordhuis@indutny@mscdex@rvagg removing your names from the collaborator guide, please join a team instead if you want to be pinged.

@louwers
louwers requested review from aduh95 and rvaggOctober 8, 2025 11:01
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 11, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025
@nodejs-github-bot
nodejs-github-bot merged commit a2f088d into nodejs:mainOct 11, 2025
26 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a2f088d

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
PR-URL: #60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
PR-URL: #60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
PR-URL: #60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 mentioned this pull request Feb 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@louwers@nodejs-github-bot@aduh95@rvagg@lpinca