Skip to content

test: mark sea tests flaky on macOS x64 - #60068

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:flakysea
Sep 30, 2025
Merged

test: mark sea tests flaky on macOS x64#60068
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:flakysea

Conversation

@richardlau

@richardlaurichardlau commented Sep 29, 2025

Copy link
Copy Markdown
Member

Refs: #59553

These tests are occasionally failing in the CI on osx13-x64, but appear to be always failing on macos15-x64 and blocking anything from landing that requires a full CI.

@richardlaurichardlau added test Issues and PRs related to the tests. macos Issues and PRs related to the macOS platform / OSX. single-executable Issues and PRs related to single-executable applications labels Sep 29, 2025
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69441/

@richardlaurichardlau added the lts-watch-v22.x PRs that may need to be released in v22.x label Sep 29, 2025
targos
targos approved these changes Sep 29, 2025
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also be OK with a SKIP, as they seem to fail 100% of the time.

@codecov

codecovBot commented Sep 29, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (c6316f9) to head (612d83c).
⚠️ Report is 116 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60068 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01% 
==========================================
Files 703 703 Lines 207546 207546 Branches 40011 40008 -3 ==========================================
- Hits 183591 183580 -11 - Misses 15949 15959 +10 - Partials 8006 8007 +1

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69442/

@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69446/

gurgunday
gurgunday approved these changes Sep 29, 2025
View reviewed changes

@gurgundaygurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSSRafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69451/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69453/

BridgeAR
BridgeAR approved these changes Sep 30, 2025
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, while I agree with @targos that skipping would be best

@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 30, 2025
@github-actions

github-actionsBot commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @BridgeAR. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69462/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69463/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69465/

@richardlau

richardlau commented Sep 30, 2025

Copy link
Copy Markdown
MemberAuthor

I would also be OK with a SKIP, as they seem to fail 100% of the time.

I went for flaky as, while they are failing 100% of the time on macOS 15 x64, they are generally passing on osx13 x64 and I don't think the Python test runner can make the distinction via the .status file. We can revisit if/when we remove osx13 from the CI.

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69471/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69474/

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2025
@nodejs-github-bot
nodejs-github-bot merged commit f304bc2 into nodejs:mainSep 30, 2025
89 checks passed
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

Landed in f304bc2

@richardlau
richardlau deleted the flakysea branch September 30, 2025 21:28
targos pushed a commit that referenced this pull request Oct 6, 2025
@richardlau@targos
test: mark sea tests flaky on macOS x64
1d5cc5e
PR-URL: #60068
Refs: #59553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
@richardlau@aduh95
test: mark sea tests flaky on macOS x64
7067d79
PR-URL: #60068
Refs: #59553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@aduh95aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Oct 11, 2025
@github-actionsgithub-actionsBot mentioned this pull request Oct 12, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
@richardlau@marco-ippolito
test: mark sea tests flaky on macOS x64
4b4e38f
PR-URL: #60068
Refs: #59553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@marco-ippolitomarco-ippolito mentioned this pull request Nov 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backported-to-v22.xPRs backported to the v22.x-staging branch.fast-trackPRs that do not need to wait for 48 hours to land.macosIssues and PRs related to the macOS platform / OSX.needs-ciPRs that need a full CI run.single-executableIssues and PRs related to single-executable applicationstestIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@richardlau@nodejs-github-bot@addaleax@lpinca@targos@cjihrig@BridgeAR@RafaelGSS@gurgunday@aduh95