Skip to content

deps: V8: cherry-pick 87356585659b - #60069

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:backport-memory-tuning
Oct 8, 2025
Merged

deps: V8: cherry-pick 87356585659b#60069
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:backport-memory-tuning

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Sep 29, 2025

Copy link
Copy Markdown
Member

Original commit message:

[flags] Ignore memory tuning flags when computing hash for code caching
Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#102443}

Refs: v8/v8@8735658

@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 29, 2025
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69499/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6780/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6780/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6780/

@joyeecheung
deps: V8: cherry-pick 87356585659b
ad03400
Original commit message:
[flags] Ignore memory tuning flags when computing hash for code caching
Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#102443}
Refs: v8/v8@8735658
@joyeecheung
joyeecheungforce-pushed the backport-memory-tuning branch from afbb6e4 to ad03400CompareOctober 8, 2025 13:08
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69620/

@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6792/

@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6792/

@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6792/

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 4eb6e6f into nodejs:mainOct 8, 2025
58 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Landed in 4eb6e6f

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
targos pushed a commit that referenced this pull request Nov 18, 2025
@joyeecheung@targos
deps: V8: cherry-pick 87356585659b
28e9433
Original commit message:
[flags] Ignore memory tuning flags when computing hash for code caching
Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#102443}
Refs: v8/v8@8735658
PR-URL: #60069
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
@legendecaslegendecaslegendecas approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung@nodejs-github-bot@addaleax@targos@richardlau@legendecas@RafaelGSS