Skip to content

module: use sync cjs when importing cts - #60072

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-59963
Oct 2, 2025
Merged

module: use sync cjs when importing cts#60072
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix-59963

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Sep 30, 2025

Copy link
Copy Markdown
Member

Fixes: #59963

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 30, 2025
@marco-ippolitomarco-ippolito changed the title module: use sync cjs loader with ctsmodule: use sync cjs when importing ctsSep 30, 2025
@codecov

codecovBot commented Sep 30, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (c6316f9) to head (b4654bc).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60072 +/- ##
=======================================
Coverage 88.45% 88.46% =======================================
Files 703 703 Lines 207546 207548 +2 Branches 40011 40004 -7 =======================================
+ Hits 183591 183597 +6 + Misses 15949 15944 -5 - Partials 8006 8007 +1
Files with missing linesCoverage Δ
lib/internal/modules/esm/loader.js96.15% <100.00%> (+<0.01%)⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69458/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69461/

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69460/

@marco-ippolito

marco-ippolito commented Sep 30, 2025

Copy link
Copy Markdown
MemberAuthor

I accidentally pressed retry in the CI

@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69466/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69485/

@marco-ippolitomarco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. strip-types Issues or PRs related to strip-types support labels Oct 1, 2025
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 69144e9 into nodejs:mainOct 2, 2025
68 of 69 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Landed in 69144e9

targos pushed a commit that referenced this pull request Oct 6, 2025
@marco-ippolito@targos
module: use sync cjs when importing cts
dbeee55
PR-URL: #60072Fixes: #59963
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
@joyeecheungjoyeecheung mentioned this pull request Oct 17, 2025
Closed
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 25, 2026
@marco-ippolito@joyeecheung
module: use sync cjs when importing cts
4aff83c
PR-URL: nodejs#60072Fixes: nodejs#59963
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@joyeecheungjoyeecheung mentioned this pull request Feb 27, 2026
Closed
marco-ippolito added a commit that referenced this pull request Apr 27, 2026
@marco-ippolito
module: use sync cjs when importing cts
39147c1
PR-URL: #60072
Backport-PR-URL: #62029Fixes: #59963
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Fixes: #61801
@marco-ippolitomarco-ippolito mentioned this pull request May 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@ZYSzysZYSzysZYSzys approved these changes
@gurgundaygurgundaygurgunday approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.strip-typesIssues or PRs related to strip-types support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node throws error when require'ing ESM module in TypeScript in nested ESM/CJS context

5 participants

@marco-ippolito@nodejs-github-bot@GeoffreyBooth@ZYSzys@gurgunday