Skip to content

test: mark test-runner-run-watch flaky on macOS - #60115

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:flakyrunnerrunwatch
Oct 5, 2025
Merged

test: mark test-runner-run-watch flaky on macOS#60115
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:flakyrunnerrunwatch

Conversation

@richardlau

@richardlaurichardlau commented Oct 3, 2025

Copy link
Copy Markdown
Member

parallel/test-runner-run-watch has failed 33 out of the last 100 CI runs on macOS. It is already marked flaky on other platforms.

Refs: #54534

@richardlau
test: mark test-runner-run-watch flaky on macOS
cd39317
`parallel/test-runner-run-watch` has failed 33 out of the last 100
CI runs on macOS. It is already marked flaky on other platforms.
@richardlaurichardlau added test Issues and PRs related to the tests. macos Issues and PRs related to the macOS platform / OSX. watch-mode Issues and PRs related to watch mode labels Oct 3, 2025
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 3, 2025
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69521/

@codecov

codecovBot commented Oct 3, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (79f1999) to head (cd39317).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60115 +/- ##
==========================================
+ Coverage 88.43% 88.46% +0.02% 
==========================================
Files 703 703 Lines 207805 207805 Branches 40026 40028 +2 ==========================================
+ Hits 183780 183830 +50 + Misses 16012 15962 -50 
Partials 8013 8013

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69528/

@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69535/

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2025
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 7c85aa5 into nodejs:mainOct 5, 2025
81 of 82 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

Landed in 7c85aa5

@richardlau
richardlau deleted the flakyrunnerrunwatch branch October 5, 2025 17:53
targos pushed a commit that referenced this pull request Oct 6, 2025
@richardlau@targos
test: mark test-runner-run-watch flaky on macOS
982b03e
`parallel/test-runner-run-watch` has failed 33 out of the last 100
CI runs on macOS. It is already marked flaky on other platforms.
PR-URL: #60115
Refs: #54534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Oct 7, 2025
Merged
@joyeecheung

joyeecheung commented Oct 22, 2025

Copy link
Copy Markdown
Member

FWIW I noticed that this test also contains a lot of test cases. We should probably split it up and only mark the persistent flakes as flaky to avoid masking regressions.

juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
@richardlau@juanarbol
test: mark test-runner-run-watch flaky on macOS
faf2140
`parallel/test-runner-run-watch` has failed 33 out of the last 100
CI runs on macOS. It is already marked flaky on other platforms.
PR-URL: nodejs#60115
Refs: nodejs#54534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request Jul 17, 2026
@richardlau@juanarbol
test: mark test-runner-run-watch flaky on macOS
c6e08cd
`parallel/test-runner-run-watch` has failed 33 out of the last 100
CI runs on macOS. It is already marked flaky on other platforms.
PR-URL: #60115
Refs: #54534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
@richardlau@marco-ippolito
test: mark test-runner-run-watch flaky on macOS
dd38ecc
`parallel/test-runner-run-watch` has failed 33 out of the last 100
CI runs on macOS. It is already marked flaky on other platforms.
PR-URL: #60115
Refs: #54534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.macosIssues and PRs related to the macOS platform / OSX.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.watch-modeIssues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau@nodejs-github-bot@joyeecheung@lpinca@cjihrig