Uh oh!
There was an error while loading. Please reload this page.
tools: remove disabling of already-disabled rule - #6013
Closed
Trott wants to merge 1 commit into
Closed
Conversation
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`.
bnoordhuis
commented
Apr 2, 2016
Member
LGTM |
2 similar comments
jasnell
commented
Apr 2, 2016
Member
LGTM |
cjihrig
commented
Apr 2, 2016
Contributor
LGTM |
jasnell pushed a commit
that referenced
this pull request
Apr 2, 2016
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: #6013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
commented
Apr 2, 2016
Member
Landed in 8832be4 |
MylesBorins pushed a commit
that referenced
this pull request
Apr 5, 2016
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: #6013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
MylesBorins
commented
Apr 11, 2016
Contributor
@Trott lts? |
Trott
commented
Apr 11, 2016
MemberAuthor
@thealphanerd Yes. |
MylesBorins pushed a commit
that referenced
this pull request
May 3, 2016
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: #6013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 6, 2016
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: #6013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 18, 2016
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: #6013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
test tools buffer
Description of change
require-bufferis only enabled in thelibdirectory. There is noneed to disable it in
test.