Skip to content

build: fix VTune builds - #60140

Closed
RReverser wants to merge 1 commit into
nodejs:mainfrom
RReverser:fix-vtune
Closed

build: fix VTune builds#60140
RReverser wants to merge 1 commit into
nodejs:mainfrom
RReverser:fix-vtune

Conversation

@RReverser

Copy link
Copy Markdown
Member

When trying to build with VTune support, I ran into couple of errors due to outdated paths in build configs.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/startup
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 7, 2025
@RReverserRReverser changed the title Fix VTune buildsbuild: fix VTune buildsOct 7, 2025
When trying to build with VTune support, I ran into couple of errors
due to outdated paths in build configs.
@richardlau

Copy link
Copy Markdown
Member

#59999 also attempts to fix the VTune builds.

@RReverser

Copy link
Copy Markdown
MemberAuthor

#59999 also attempts to fix the VTune builds.

Ah didn't see that one. The only difference seems to be that you changed include_dirs to include the V8 root and I changed the path to jitprofiling.h to be relative.

I'm happy with either one to land.

@codecov

codecovBot commented Oct 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (b757a8f) to head (e314102).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60140 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.02% 
==========================================
Files 703 703 Lines 207804 207804 Branches 40005 40010 +5 ==========================================
- Hits 183989 183953 -36 - Misses 15817 15863 +46 + Partials 7998 7988 -10 
Files with missing linesCoverage Δ
src/api/environment.cc77.46% <ø> (+0.51%)⬆️
src/node.cc76.07% <ø> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RReverser

Copy link
Copy Markdown
MemberAuthor

Closing since #59999 was merged. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@RReverser@nodejs-github-bot@richardlau