Skip to content

test: ensure assertions are reachable in test/async-hooks - #60150

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:must-call-mustCalls-asynchooks
Oct 9, 2025
Merged

test: ensure assertions are reachable in test/async-hooks#60150
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:must-call-mustCalls-asynchooks

Conversation

@aduh95

@aduh95aduh95 commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Another follow up of #60125

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 7, 2025
@codecov

codecovBot commented Oct 7, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (b13f24c) to head (7b5d633).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60150 +/- ##
=======================================
Coverage 88.53% 88.53% =======================================
Files 703 703 Lines 207997 207997 Branches 40015 40018 +3 =======================================
+ Hits 184150 184157 +7 + Misses 15864 15858 -6 + Partials 7983 7982 -1

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 8, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69630/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-bot
nodejs-github-bot merged commit bfc81ca into nodejs:mainOct 9, 2025
73 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in bfc81ca

@aduh95
aduh95 deleted the must-call-mustCalls-asynchooks branch October 10, 2025 20:10
@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 added a commit that referenced this pull request Nov 11, 2025
@aduh95
test: ensure assertions are reachable in test/async-hooks
e5a8122
PR-URL: #60150
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2025
Merged
aduh95 added a commit that referenced this pull request Feb 17, 2026
@aduh95
test: ensure assertions are reachable in test/async-hooks
25f10c6
PR-URL: #60150
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 added a commit that referenced this pull request Feb 19, 2026
@aduh95
test: ensure assertions are reachable in test/async-hooks
9fcf889
PR-URL: #60150
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@aduh95aduh95 mentioned this pull request Feb 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@cjihrig@atlowChemi