Skip to content

lib: fix typo in QuicSessionStats - #60155

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
SeokhunEom:privateSynbol-typo
Oct 10, 2025
Merged

lib: fix typo in QuicSessionStats#60155
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
SeokhunEom:privateSynbol-typo

Conversation

@SeokhunEom

@SeokhunEomSeokhunEom commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Corrects the misspelling of "privateSynbol" to "privateSymbol".

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 8, 2025
@codecov

codecovBot commented Oct 8, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (535efea) to head (17d993a).
⚠️ Report is 7 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/quic/stats.js66.66%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #60155 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.03% 
==========================================
Files 704 704 Lines 208081 208081 Branches 40011 40010 -1 ==========================================
- Hits 184270 184220 -50 - Misses 15826 15867 +41 - Partials 7985 7994 +9
Files with missing linesCoverage Δ
lib/internal/quic/stats.js95.31% <66.66%> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SeokhunEomSeokhunEom mentioned this pull request Oct 8, 2025
Closed
@Hritikk999

Hritikk999 commented Oct 8, 2025

Copy link
Copy Markdown

1 Failed, 20 successful checks

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@SeokhunEom
lib: fix typo in QuicSessionStats
17d993a
Corrects the misspelling of "privateSynbol" to "privateSymbol".
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69634/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2025
@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 4daeec1 into nodejs:mainOct 10, 2025
64 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

Landed in 4daeec1

@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
@SeokhunEom@aduh95
lib: fix typo in QuicSessionStats
caafda2
Corrects the misspelling of "privateSynbol" to "privateSymbol".
PR-URL: #60155
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
@SeokhunEom@aduh95
lib: fix typo in QuicSessionStats
4f7745a
Corrects the misspelling of "privateSynbol" to "privateSymbol".
PR-URL: #60155
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
@SeokhunEom@aduh95
lib: fix typo in QuicSessionStats
f9d87fb
Corrects the misspelling of "privateSynbol" to "privateSymbol".
PR-URL: #60155
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95aduh95 mentioned this pull request Feb 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SeokhunEom@Hritikk999@nodejs-github-bot@jasnell@lpinca@richardlau