Skip to content

test: skip quic tests that IBM i does not support - #60160

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sravani1510:ibmi-skip-test-quic
Oct 10, 2025
Merged

test: skip quic tests that IBM i does not support#60160
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sravani1510:ibmi-skip-test-quic

Conversation

@sravani1510

Copy link
Copy Markdown
Contributor

Similar to AIX, IBM i does not support certain
network flags and we also skip the following
tests like on AIX

  • parallel.test-quic-test-client.mjs
  • parallel.test-quic-test-server.mjs

Refer: #60073

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 8, 2025
@codecov

codecovBot commented Oct 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (d52cd04) to head (42a5b3a).
⚠️ Report is 338 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60160 +/- ##
==========================================
+ Coverage 88.52% 88.55% +0.02% 
==========================================
Files 703 703 Lines 207997 207997 Branches 40024 40017 -7 ==========================================
+ Hits 184134 184183 +49 + Misses 15875 15821 -54 - Partials 7988 7993 +5 

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2025
@nodejs-github-bot
nodejs-github-bot merged commit e105e82 into nodejs:mainOct 10, 2025
69 of 70 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in e105e82

@sravani1510
sravani1510 deleted the ibmi-skip-test-quic branch October 10, 2025 09:29
@abmusseabmusse added the ibm i Issues and PRs related to the IBM i platform. label Oct 10, 2025
@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
9 tasks
@targostargos added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 18, 2025
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 30, 2026
PR-URL: nodejs#60160
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.ibm iIssues and PRs related to the IBM i platform.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@sravani1510@nodejs-github-bot@jasnell@lpinca@cjihrig@richardlau@targos@abmusse