Skip to content

test: ensure assertions are reachable in test/client-proxy - #60175

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:must-call-mustCalls-client-proxy
Oct 12, 2025
Merged

test: ensure assertions are reachable in test/client-proxy#60175
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:must-call-mustCalls-client-proxy

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

Another follow up of #60125

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 9, 2025
@codecov

codecovBot commented Oct 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (e105e82) to head (aff6d5b).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #60175 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.02% 
==========================================
Files 704 704 Lines 208087 208087 Branches 40006 40005 -1 ==========================================
+ Hits 184223 184273 +50 + Misses 15869 15825 -44 + Partials 7995 7989 -6 

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
aduh95force-pushed the must-call-mustCalls-client-proxy branch from a4ba32e to aff6d5bCompareOctober 10, 2025 20:15
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@atlowChemiatlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit da9cd74 into nodejs:mainOct 12, 2025
60 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in da9cd74

@aduh95
aduh95 deleted the must-call-mustCalls-client-proxy branch October 12, 2025 20:47
@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
9 tasks
aduh95 added a commit that referenced this pull request Nov 11, 2025
PR-URL: #60175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
PR-URL: nodejs#60175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
juanarbol pushed a commit that referenced this pull request Jul 17, 2026
PR-URL: #60175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
juanarbol pushed a commit that referenced this pull request Jul 19, 2026
PR-URL: #60175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
PR-URL: #60175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@cjihrig@atlowChemi