Skip to content

vm: hint module identifier in instantiate errors - #60199

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:vm-error
Oct 12, 2025
Merged

vm: hint module identifier in instantiate errors#60199
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:vm-error

Conversation

@legendecas

@legendecaslegendecas commented Oct 10, 2025•
edited by aduh95
Loading

Copy link
Copy Markdown
Member

Improves the error message on vm.SourceTextModule link errors.

Fixes: #60157

@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 10, 2025
addaleax
addaleax reviewed Oct 10, 2025
View reviewed changes
Comment threadsrc/node_errors.h Outdated
Comment threadsrc/module_wrap.cc Outdated
@codecov

codecovBot commented Oct 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (e105e82) to head (43d6b6b).
⚠️ Report is 13 commits behind head on main.

Files with missing linesPatch %Lines
src/module_wrap.cc66.66%4 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #60199 +/- ##
=======================================
Coverage 88.53% 88.53% =======================================
Files 704 704 Lines 208087 208085 -2 Branches 40006 40004 -2 =======================================
+ Hits 184223 184224 +1 - Misses 15869 15871 +2 + Partials 7995 7990 -5
Files with missing linesCoverage Δ
src/module_wrap.h52.94% <ø> (ø)
src/node_errors.h86.48% <100.00%> (-0.70%)⬇️
src/module_wrap.cc75.27% <66.66%> (-0.34%)⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69682/

@nodejs-github-bot

nodejs-github-bot commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69687/

@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 1986ee4 into nodejs:mainOct 12, 2025
64 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in 1986ee4

@legendecas
legendecas deleted the vm-error branch October 12, 2025 15:54
@RafaelGSSRafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
targos pushed a commit that referenced this pull request Nov 18, 2025
@legendecas@targos
vm: hint module identifier in instantiate errors
884fe88
PR-URL: #60199Fixes: #60157
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@aduh95aduh95aduh95 approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VM Module linking unclear error message

6 participants

@legendecas@nodejs-github-bot@addaleax@cjihrig@aduh95@RaisinTen